Open
Conversation
* Always send `X-Content-Type-Options: nosniff` to prevent detection of content type * Add `Vary: Accept` to inform clients that the response depends on the Accept header * Fix `Allow` header when invalid method was used * Always send 404 Not found with `text/plain` content type * Always send the `Cache-control: public` header
byo
force-pushed
the
cleanup-delegated-routing-response-headers
branch
from
37b7302 to
12a1396
Compare
nymd
reviewed
May 7, 2026
| h.Add("X-Content-Type-Options", "nosniff") | ||
| h.Add("Vary", "Accept") | ||
| h.Add("Cache-Control", "public") | ||
|
|
There was a problem hiding this comment.
Maybe max-age is a good addition as well so we are specific about acceptable staleness.
willscott
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
X-Content-Type-Options: nosniffto prevent detection of content typeVary: Acceptto inform clients that the response depends on the Accept headerAllowheader when invalid method was usedtext/plaincontent typeCache-control: publicheader