Code reuse and a question #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding some code reuse adding missing paren adding missing paren
Contributor
|
I think that after your change the function checks isIntersects and not isInside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can reuse existing method logic instead of recreating them in inverse, and is there a reason that item.rect().width and item.rect().height is not taken into account for isRightOf and isBelow? ..... This question extends to forceInside?
So basically, the only reason I noticed the code reuse issue is that I was trying to understand why I had to adjust by the width of the sprite to check if the player was to the right of the viewport but not to the left... So my question is, feature or bug?