netif: fix empty bond offload features

[lxchx]

In DPDK, the bonding device's offload_capa is derived from the intersection of its slaves'. If no slaves are added, offload_capa defaults to 0. To utilize the offload features of slaves, slaves must beadded before configuring the bonding device.

This patch adjusts the sequence of add_bond_slaves and rte_eth_dev_configure calls, enabling the bonding device to correctly leverage slave offload capabilities and enhancing forwarding efficiency.

[Copilot]

Pull Request Overview

This PR fixes the issue where bonding devices with no slaves lead to offload features being disabled by reordering the call to add slaves before configuring the device. Key changes include:

• Insertion of a call to setup_dev_of_flags in add_bond_slaves.
• Moving the add_bond_slaves call in netif_port_start to precede device configuration.
• Removal of the duplicate add_bond_slaves call later in netif_port_start.

Comments suppressed due to low confidence (2)

src/netif.c:3943

• Since setup_dev_of_flags is now called immediately after updating dev_info, consider verifying that the dev_info update was successful to ensure the offload flags are applied to valid device information.

setup_dev_of_flags(port);

src/netif.c:3980

• The reordering of the add_bond_slaves call in netif_port_start effectively avoids duplicate invocations; please double-check that all bonding-specific configurations now only occur before the device configuration to prevent any unintended side-effects.

if (port->type == PORT_TYPE_BOND_MASTER) {