Skip to content

ipvs: Optimize TOA insertion performance using memmove #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

lxchx
Copy link
Contributor

@lxchx lxchx commented Mar 21, 2025

No description provided.

@lxchx lxchx changed the base branch from master to devel March 21, 2025 07:18
@ywc689 ywc689 added the pr/to-review-codes review codes line by line and check if problem exists. label Mar 23, 2025
@lxchx lxchx force-pushed the toa-optimization branch from 997dc85 to 757aa19 Compare March 24, 2025 08:32
@lxchx lxchx force-pushed the toa-optimization branch from 757aa19 to a7f6fc8 Compare March 31, 2025 09:45
@ywc689 ywc689 requested a review from Copilot April 28, 2025 01:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes the insertion of TCP TOA options by replacing a manual byte-by-byte shifting loop with an efficient memmove call.

  • Replaced manual reverse loop with memmove.
  • Introduced new variables (src, dst, move_len) to improve code clarity and performance.

@ywc689 ywc689 self-requested a review April 28, 2025 01:31
@ywc689 ywc689 added pr/codes-reviewed-ok code review passed and no problem found pr/accepted the pr passed all review stages and await to be merged and removed pr/to-review-codes review codes line by line and check if problem exists. labels Apr 29, 2025
@ywc689 ywc689 merged commit 605c239 into iqiyi:devel Apr 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/accepted the pr passed all review stages and await to be merged pr/codes-reviewed-ok code review passed and no problem found
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants