Add Android NDK 28+ compatibility fixes #110
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essential changes: - Fix PAGE_SIZE/PAGE_MASK undefined errors in NDK 28+ - Replace compile-time constants with runtime functions for flexible page size support - Support both 4KB and 16KB page sizes as required by Android 15+ Minimal build changes: - Remove deprecated armeabi ABI (NDK 28 no longer supports it) - Keep android-14 platform (NDK automatically upgrades to android-21) Technical implementation: - Add get_page_size() and get_page_mask() runtime functions in xh_util.c - Use sysconf(_SC_PAGESIZE) for runtime page size detection Tested with NDK 28.2.13676358 - all architectures build successfully. 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essential changes:
Minimal build changes:
Technical implementation:
Tested with NDK 28.2.13676358 - all architectures build successfully.