Skip to content

Conversation

@olebole
Copy link
Member

@olebole olebole commented Nov 12, 2025

This started from NOIRLAB:

  • c9dc421 removed typo code from pr_mask()
  • a835f6c added coded accidently previously deleted
  • 841034e code ordering

The first commit message was however misleading. For the PR, the commits were split into a number of individual changes:

  • Fix few typos in comments
  • Use ssh by default to call remote kernel (written as new commit)
  • Make some variables volatile: This seems (except for unauth in ZOPNKS()) not really necessary, but it also doesn't harm (except for performance, which isn't an issue here).

There were a few changes in the original commit that are not applied here. Except from removing re-entrance possibility, they don't change behaviour:

  • Make op and nbytes static in ZARDKS()

    @@ -917,13 +917,9 @@ ZARDKS (
       XLONG	*loffset 		/* not used				*/
     )
     {
    -#ifdef ANSI
    -	volatile char	*op;
    -	volatile int	fd, nbytes;
    -#else
    -	char	*op;
    -	int	fd, nbytes;
    -#endif
    +	static  char	*op;
    +	static  int	nbytes;
    +	int	fd;
     	void	(*sigint)(int), (*sigterm)(int);
     	int	status = ERR;
  • Make irafhost, nodelist and update static in ks_getlogin()

    @ -1393,15 +1393,16 @@ ks_getlogin (
       struct ksparam *ks 		/* networking parameters */
     )
     {
    +	static struct irafhosts *hp = (struct irafhosts *)NULL;
    +	static struct	nodelist *np = (struct nodelist *)NULL;
    +	static int	update = 0;
    +
     	register int i;
    -	struct  irafhosts *hp;
     	char	userfile[SZ_PATHNAME];
     	char	sysfile[SZ_PATHNAME];
     	char	fname[SZ_PATHNAME];
     	char	username[SZ_NAME];
     	char	*namep, *authp;
    -	struct	nodelist *np;
    -	int	update = 0;
     	int	auth;
     
     	/* Get path to user irafhosts file. */

Also, the extensive addition of unconditional debug messages was not applied here.

Pinging @mjfitzpatrick for a potential discussion.

@olebole olebole changed the title Use ssh by default to call remote kernel NOIRLAB: Use ssh by default to call remote kernel Nov 12, 2025
@olebole olebole force-pushed the noirlab-ssh branch 2 times, most recently from fbcda70 to 38a717e Compare November 24, 2025 08:13
mjfitzpatrick and others added 3 commits January 1, 2026 14:28
This was split from the original commit from Mike Fitzpatrick
This was split from the original commit from Mike Fitzpatrick
@olebole olebole force-pushed the noirlab-ssh branch 2 times, most recently from b580ac6 to cec9ddb Compare January 1, 2026 15:57
jmpset may be changed in setjmp or in a signal handler, so this
is required to ensure it is not optimized away and is signal safe.

https://en.cppreference.com/w/c/program/sig_atomic_t
NOwadays we always can assume an ANSI compliant compiler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants