NOIRLAB: Use ssh by default to call remote kernel #453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started from NOIRLAB:
The first commit message was however misleading. For the PR, the commits were split into a number of individual changes:
There were a few changes in the original commit that are not applied here. Except from removing re-entrance possibility, they don't change behaviour:
Make op and nbytes static in ZARDKS()
Make irafhost, nodelist and update static in ks_getlogin()
@ -1393,15 +1393,16 @@ ks_getlogin ( struct ksparam *ks /* networking parameters */ ) { + static struct irafhosts *hp = (struct irafhosts *)NULL; + static struct nodelist *np = (struct nodelist *)NULL; + static int update = 0; + register int i; - struct irafhosts *hp; char userfile[SZ_PATHNAME]; char sysfile[SZ_PATHNAME]; char fname[SZ_PATHNAME]; char username[SZ_NAME]; char *namep, *authp; - struct nodelist *np; - int update = 0; int auth; /* Get path to user irafhosts file. */Also, the extensive addition of unconditional debug messages was not applied here.
Pinging @mjfitzpatrick for a potential discussion.