Add Windows CI and refactor workflow layout#137
Conversation
rsuderman
force-pushed
the
win_ci
branch
12 times, most recently
from
1a66e99 to
67f92c5
Compare
Signed-off-by: Rob Suderman <rob.suderman@gmail.com>
Signed-off-by: Rob Suderman <rob.suderman@gmail.com>
Signed-off-by: Rob Suderman <rob.suderman@gmail.com>
rsuderman
changed the title
|
|
||
| python3 -m pip install --upgrade pip | ||
| python3 -m pip install lit filecheck | ||
| python3 -m pip install --find-links https://iree.dev/pip-release-links.html iree-base-compiler==3.11.0rc20260203 |
There was a problem hiding this comment.
This is probably the 4th place where we're specifying an IREE version (aside from CMakeLists.txt, pebble config, fusilli docker) :D
Don't have to address here unless it's quick but we probably need to consolidate to a single version file as source of truth.
There was a problem hiding this comment.
I think I can fix this up but it will require changing some of the CIs. I wanted to avoid making any substantial changes to the linux CI until after the windows one is in place.
| refreshenv | ||
| - name: "Building Fusilli" | ||
| run: | | ||
| cmake -S . -B ${{ env.BUILD_DIR_POWERSHELL}} -G Ninja -DCMAKE_BUILD_TYPE=Release -DFUSILLI_ENABLE_LOGGING=ON -DFUSILLI_SYSTEMS_AMDGPU=OFF |
There was a problem hiding this comment.
I think it's safer to have this point to a clone of IREE at the specific nightly commit, to keep it in sync with the compiler binary. You can then point to it with -DIREE_SOURCE_DIR. Without that we basically FetchContent the version specified in the CMakeLists.txt: https://sourcegraph.com/github.com/iree-org/fusilli/-/blob/CMakeLists.txt?L114
There was a problem hiding this comment.
Let me handle this in a follow up. I think its not bad to fix but for now I wanted to focus on the CIs matching eachothers behavior.
| - name: "Running Fusilli tests (libIREECompiler CAPI)" | ||
| run: | | ||
| ctest --test-dir ${{ env.BUILD_DIR_POWERSHELL}} --output-on-failure --extra-verbose --timeout 120 |
There was a problem hiding this comment.
Is CLI not supported on Windows?
There was a problem hiding this comment.
I can enable it if you want, I wanted to avoid making the windows CI take longer. than it will already be. With the IREE CI we have found that windows tends to be much slower so minimizing to MVP tends to do wonders for CI runtime. If not I can add it back in.
There was a problem hiding this comment.
It's not super critical, just checking. The main use-case for CLI is for debugging / sharing repros, and right now this is fine since we're just developing / debugging on Linux, but when we see users actively developing on Windows flows, we can revisit this.
Signed-off-by: Rob Suderman <rob.suderman@gmail.com>
2 participants
Summary
build-and-test.ymlinto separate platform-specific reusable workflows (build-and-test-linux.ymlandbuild-and-test-win.yml), called from the main workflow viaworkflow_callcpu_msvc_windows) running onazure-windows-scalerunners, building with Ninja in Release mode (GPU disabled)+=operator insamples/reduction/reduction_ops.cppto use explicit addition for MSVC compatibility🤖 Generated with Claude Code