Fix: Wrong handle in multi-stream handle test#186
Merged
Conversation
The second buffer allocate/read in "Create multiple handles with different HIP streams" was using handle1 instead of handle2, causing a cross-stream race that resulted in flaky D2H reads of all zeros. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Sambhav Jain <sambhav@alumni.stanford.edu>
AaronStGeorge
approved these changes
Feb 24, 2026
Contributor
The fix is definitely what we want, but I'm a little lost as to why it would cause a race condition. Everything should have been stream ordered on handle 1. |
Member
Author
Hence my prefix on what Claude generated :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multi-stream handle test failed flakily on a recent CI run on
main: https://github.com/iree-org/fusilli/actions/runs/22334529677/job/64623964052test_handle.cppwhere the "Create multiple handles with different HIP streams" test was usinghandle1instead ofhandle2for the second buffer'sallocateandreadcalls3.14fvalues🤖 Generated with Claude Code