Add HIP graph lifecycle and query coverage - #7
Open
AWoloszyn wants to merge 1 commit into
Open
Conversation
Add focused graph template tests for the APIs that expose graph structure directly: dependency insertion, node enumeration, root-node enumeration, node type lookup, node destruction, and repeated instantiate/destroy sequencing. The cases cover both successful empty-node graphs and invalid inputs such as null node arrays, duplicate dependencies, self-dependencies, cross-graph dependencies, and null node handles. These tests pin down the observable graph editing contract instead of only checking that a graph can be created. They verify that query APIs report the counts and handles a caller can actually consume, that destroyed nodes disappear from later graph queries, and that invalid dependency edges fail before they mutate the graph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add focused graph template tests for the APIs that expose graph structure directly: dependency insertion, node enumeration, root-node enumeration, node type lookup, node destruction, and repeated instantiate/destroy sequencing. The cases cover both successful empty-node graphs and invalid inputs such as null node arrays, duplicate dependencies, self-dependencies, cross-graph dependencies, and null node handles.
These tests pin down the observable graph editing contract instead of only checking that a graph can be created. They verify that query APIs report the counts and handles a caller can actually consume, that destroyed nodes disappear from later graph queries, and that invalid dependency edges fail before they mutate the graph.