Skip to content

[NFC] Add logging#1059

Open
AaronStGeorge wants to merge 1 commit into
iree-org:mainfrom
AaronStGeorge:log-mlir
Open

[NFC] Add logging#1059
AaronStGeorge wants to merge 1 commit into
iree-org:mainfrom
AaronStGeorge:log-mlir

Conversation

@AaronStGeorge

Copy link
Copy Markdown
Contributor

While working on a recent change I found the logging here very convenient, maybe it should be permanent?

While working on a recent change I found the logging here very
convenient, maybe it should be permanent?
@AaronStGeorge AaronStGeorge requested a review from zjgarvey July 15, 2025 14:45

@ftynse ftynse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was adding a breakpoint at this place to inspect the program, so looks helpful.

@zjgarvey

Copy link
Copy Markdown
Contributor

I do think this might be a bit aggressive logging for other use-cases of aot.export (e.g. full models with thousands of lines of IR), but I'm fine with this.

If we want to move away from using aot.export/CompiledModule in BOO, I'm fine with that too. We are essentially only using the torch.export, fx_importer, and CustomOpExpansionPass pieces of this tech, so it might just make more sense to just use those directly and do the logging in BOO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants