[BOO] Sync after profiling to fix flaky event loss#1329
Draft
rkayaith wants to merge 1 commit into
Draft
Conversation
f4747c8 to
ec10ac6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronize GPU in the BOO driver's profiling loop. We've been getting flaky failures in
tests/kernel/boo/driver/cli_test.pywith dispatches not being captured by the profiler, and I found that synchronizing in two places resolves the issue:prof.step()— ensures in-flight GPU kernels complete before the profiler advances stateThe torch profiler context already includes a synchronize in its
__exit__so that all events are captured, so this seems to be something to do with needing to synchronize after the profiler's cleanup.Fixes #1327