Skip to content

[VectorExt] Add TransferScatterOp definition, verifier, lit tests.#23666

Merged
keshavvinayak01 merged 3 commits intoiree-org:mainfrom
keshavvinayak01:users/keshavvinayak01/transfer-scatter-1-op-definition
Mar 7, 2026
Merged

[VectorExt] Add TransferScatterOp definition, verifier, lit tests.#23666
keshavvinayak01 merged 3 commits intoiree-org:mainfrom
keshavvinayak01:users/keshavvinayak01/transfer-scatter-1-op-definition

Conversation

@keshavvinayak01
Copy link
Copy Markdown
Contributor

@keshavvinayak01 keshavvinayak01 commented Mar 5, 2026

Introduce iree_vector_ext.transfer_scatter, the write counterpart to transfer_gather. Uses the same unified indexing_maps attribute with per-dimension control (contiguous, scattered, broadcast).

For tensor operands the op returns the modified tensor; for memref operands it has no result.

Part 1/4 from #23610

@keshavvinayak01 keshavvinayak01 force-pushed the users/keshavvinayak01/transfer-scatter-1-op-definition branch from 4b9697a to 899acd9 Compare March 5, 2026 14:10
@keshavvinayak01 keshavvinayak01 requested a review from hanhanW March 5, 2026 15:07
Comment thread compiler/src/iree/compiler/Codegen/Dialect/VectorExt/IR/VectorExtOps.td Outdated
Comment thread compiler/src/iree/compiler/Codegen/Dialect/VectorExt/IR/VectorExtOps.td Outdated
Comment thread compiler/src/iree/compiler/Codegen/Dialect/VectorExt/IR/VectorExtOps.td Outdated
Comment thread compiler/src/iree/compiler/Codegen/Dialect/VectorExt/IR/test/roundtrip.mlir Outdated
Comment thread compiler/src/iree/compiler/Codegen/Dialect/VectorExt/IR/test/roundtrip.mlir Outdated
Comment thread compiler/src/iree/compiler/Codegen/Dialect/VectorExt/IR/test/roundtrip.mlir Outdated
@keshavvinayak01 keshavvinayak01 force-pushed the users/keshavvinayak01/transfer-scatter-1-op-definition branch from 899acd9 to 71e6351 Compare March 6, 2026 11:42
@keshavvinayak01 keshavvinayak01 requested a review from hanhanW March 6, 2026 14:08
Comment thread compiler/src/iree/compiler/Codegen/Dialect/VectorExt/IR/VectorExtOps.td Outdated
Comment thread compiler/src/iree/compiler/Codegen/Dialect/VectorExt/IR/VectorExtOps.td Outdated
Copy link
Copy Markdown
Contributor

@Groverkss Groverkss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

@keshavvinayak01 keshavvinayak01 force-pushed the users/keshavvinayak01/transfer-scatter-1-op-definition branch from fecb84b to b31dbff Compare March 6, 2026 20:07
Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
@keshavvinayak01 keshavvinayak01 force-pushed the users/keshavvinayak01/transfer-scatter-1-op-definition branch from b31dbff to 0adaf2e Compare March 6, 2026 20:08
Copy link
Copy Markdown
Contributor Author

@keshavvinayak01 keshavvinayak01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Groverkss Done.

Copy link
Copy Markdown
Contributor

@hanhanW hanhanW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. It'd be good if you can address comment in a separate commit. That will help review process much easier as I don't need to re-read all the code.

Comment thread compiler/src/iree/compiler/Codegen/Dialect/VectorExt/IR/VectorExtOps.td Outdated
Comment thread compiler/src/iree/compiler/Codegen/Dialect/VectorExt/IR/VectorExtOps.td Outdated
keshavvinayak01 and others added 2 commits March 7, 2026 17:50
…ExtOps.td

Co-authored-by: Han-Chung Wang <hanhan0912@gmail.com>
…ExtOps.td

Co-authored-by: Han-Chung Wang <hanhan0912@gmail.com>
@keshavvinayak01 keshavvinayak01 enabled auto-merge (squash) March 7, 2026 12:22
@keshavvinayak01 keshavvinayak01 merged commit 16155fd into iree-org:main Mar 7, 2026
55 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants