[NFC][Codegen] Move distribution pattern infrastructure to VectorExt#23669
Merged
Groverkss merged 1 commit intoiree-org:mainfrom Mar 6, 2026
Merged
Conversation
…Transforms
Move DistributionPattern, VectorLayoutOptions, DistributionSignature,
and related signature utility functions from Codegen/Common/GPU/ into
Codegen/Dialect/VectorExt/Transforms/DistributionPatterns.{h,cpp}.
The concrete NestedLayout distribution patterns remain in Common/GPU/
to avoid pulling Codegen-level dependencies into the VectorExt dialect
layer.
This change allows us to define distribution patterns outside of
Common/GPU without having a dependency on Common/GPU. This allows us to
define new patterns by only taking a dependency on VectorExtTransforms.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Groverkss
requested review from
MaheshRavishankar,
Max191,
hanhanW,
krzysz00,
kuhar,
nirvedhmeshram and
qedawkins
as code owners
MaheshRavishankar
approved these changes
Mar 5, 2026
AGindinson
approved these changes
Mar 6, 2026
Contributor
AGindinson
left a comment
AGindinson
left a comment
There was a problem hiding this comment.
LGTM
Do I understand correctly that the original infra in GPUVectorDistribution.cpp has not been unit-tested so far? Or am I missing some LITs that could also be converted into VectorExt dialect tests?
Contributor
Author
There are unit tests, they live in Common/GPU/test/gpu_nested... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move DistributionPattern, VectorLayoutOptions, DistributionSignature, and related signature utility functions from Codegen/Common/GPU/ into Codegen/Dialect/VectorExt/Transforms/DistributionPatterns.{h,cpp}.
The concrete NestedLayout distribution patterns remain in Common/GPU/ to avoid pulling Codegen-level dependencies into the VectorExt dialect layer.
This change allows us to define distribution patterns outside of Common/GPU without having a dependency on Common/GPU. This allows us to define new patterns by only taking a dependency on VectorExtTransforms.