You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some places in the project used Grey while others used Gray.
Since in IT the American spelling Gray is more common, this PR updates everything to match.
Just a small cleanup to keep things consistent and easier to read for everyone.
Semi.Avalonia is implemented based on Semi Design, the spelling of Grey is also follow Semi Design standard.
You could see the Tokens for the reason why using Grey.
@zdpcdt Thanks for the reply! I understand that Semi Design uses Grey and it makes sense to stay consistent with the design system.
In .NET and Avalonia the spelling Gray is standard. For example Avalonia.Media.Colors.Gray. In CSS both gray and grey exist, but Avalonia itself only supports Gray.
Maybe it could be good to support both spellings. Grey would stay for compatibility with Semi Design, and Gray would make it more natural for developers who already use Avalonia and .NET.
That way we keep the link with Semi Design and also make things a bit smoother for Avalonia developers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some places in the project used
Greywhile others usedGray.Since in IT the American spelling
Grayis more common, this PR updates everything to match.Just a small cleanup to keep things consistent and easier to read for everyone.