Fix PopConfirm crash when Placement is PlacementMode.Custom - #1072
Merged
Conversation
Co-authored-by: rabbitism <14807942+rabbitism@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix crash issue in PopConfirm when placement is custom
Fix PopConfirm crash when Placement is PlacementMode.Custom
Sep 4, 2026
rabbitism
approved these changes
Sep 4, 2026
rabbitism
marked this pull request as ready for review
September 4, 2026 14:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
PopConfirm.PlacementtoPlacementMode.Customcrashed the application, sinceCustomrequires a positioning delegate thatPopConfirmdoes not supply.Changes
PopConfirm.PlacementProperty: added a coerce callback that mapsPlacementMode.CustomtoPlacementMode.Center, leaving all other values untouched.Customcoerces toCenterand non-Customvalues (e.g.Top) are preserved.Note
The test suite could not be executed in this environment because the Avalonia nightly NuGet feed is unreachable (
NU1301), blocking package restore.