Skip to content

Improve error message when you forget to parameterize a call with [cpp_xxx] #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

gordonwatts
Copy link
Member

@gordonwatts gordonwatts commented Mar 21, 2025

  • Detect the user is trying to call soemthing that isn't a method/function, and print an error message with context.

Fixes #160

@gordonwatts gordonwatts self-assigned this Mar 21, 2025
@gordonwatts gordonwatts added bug Something isn't working enhancement New feature or request labels Mar 21, 2025
@gordonwatts gordonwatts marked this pull request as ready for review March 21, 2025 18:53
@gordonwatts gordonwatts changed the title Fix up error message Improve error message when you forget to parameterize a call with [cpp_xxx] Mar 21, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.44%. Comparing base (8f97702) to head (31e217b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #185   +/-   ##
=======================================
  Coverage   97.43%   97.44%           
=======================================
  Files          15       15           
  Lines        1367     1369    +2     
=======================================
+ Hits         1332     1334    +2     
  Misses         35       35           
Flag Coverage Δ
unittests 97.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gordonwatts gordonwatts merged commit ed624ca into master Mar 21, 2025
16 checks passed
@gordonwatts gordonwatts deleted the bug/fix-up-param-error-msg branch March 21, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message when missing [] on method is not helpful.
2 participants