Skip to content

Make sure Range isn't Replaced #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025
Merged

Make sure Range isn't Replaced #190

merged 3 commits into from
Apr 10, 2025

Conversation

gordonwatts
Copy link
Member

The Range function was including some unecessary code - which was accidentally triggering some funny behavior in the xAOD backend.

Fixes #189

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.37%. Comparing base (2b760c4) to head (791393a).

Files with missing lines Patch % Lines
func_adl/functions.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
- Coverage   97.37%   97.37%   -0.01%     
==========================================
  Files          15       15              
  Lines        1410     1409       -1     
==========================================
- Hits         1373     1372       -1     
  Misses         37       37              
Flag Coverage Δ
unittests 97.37% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gordonwatts gordonwatts marked this pull request as ready for review April 10, 2025 06:33
@gordonwatts gordonwatts self-assigned this Apr 10, 2025
@gordonwatts gordonwatts added the bug Something isn't working label Apr 10, 2025
@gordonwatts gordonwatts merged commit cd33232 into master Apr 10, 2025
16 checks passed
@gordonwatts gordonwatts deleted the big/range branch April 10, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Range is no longer being correctly interpreted
2 participants