build: Add packaging build system#3
Open
matthewfeickert wants to merge 1 commit intoiris-hep:mainfrom
Open
Conversation
* Use src/ directory layout. * Add missing metadata, such as requires-python. * Add packaging support using hatch build-system.
Member
Author
|
@gordonwatts This doesn't address your question from the other day fully, but this allows for things to be packaged correctly, which allows for PR #4, which will start to simplify things. This is ready for review. |
matthewfeickert
commented
Feb 11, 2025
| description = "Commands for working with func_adl types" | ||
| readme = "README.md" | ||
| license = { text = "MIT" } | ||
| requires-python = ">=3.8" |
Member
Author
There was a problem hiding this comment.
I'm setting this here as it is really important to set some Python version. If this needs to get bumped down to Python 3.7 that's fine, but it shouldn't be absent.
Member
|
Thanks for this. I'm slowly learning about this in other packages (which are much younger). I'll come back to this MR as I get more confident that I understand your proposed changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add packaging support. Enables