Skip to content

Add Rahul Chauhan to the team page #2497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2025

Conversation

dynamic-entropy
Copy link
Contributor

No description provided.

Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dynamic-entropy 👋 Glad you're joining the team! Can you fixup the schema errors that were caught by pre-commit?

Comment on lines 2 to 4
focus-area:
- XrootD
- FTS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check people files.......................................................Failed
- hook id: check-jsonschema
- exit code: 1

ok -- validation done
Schema validation errors were encountered.
  _data/people/dynamic-entropy.yml::$.focus-area[0]: 'XrootD' is not one of ['as', 'ia', 'ssc', 'doma', 'ssl', 'osglhc', 'core']
  _data/people/dynamic-entropy.yml::$.focus-area[1]: 'FTS' is not one of ['as', 'ia', 'ssc', 'doma', 'ssl', 'osglhc', 'core']

focusa-area is supposed to map to institute focus areas.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @matthewfeickert
I have addressed the changes requested in the validation check.

Cheers

@matthewfeickert
Copy link
Member

@dynamic-entropy as a heads up for the future, please never make PRs from the default branch of the upstream repo. This makes it so it is impossible to rebase the PR without closing the PR and also means that you'll have to do some Git surgery later on as we squash the PRs and so your fork's default branch will now be badly out of sync with the upstream's.

@matthewfeickert matthewfeickert merged commit 512bf2c into iris-hep:master Mar 1, 2025
2 checks passed
@dynamic-entropy
Copy link
Contributor Author

Sure, I have made a note.
I will simply reset my master with upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants