-
Notifications
You must be signed in to change notification settings - Fork 356
Add Rahul Chauhan to the team page #2497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dynamic-entropy 👋 Glad you're joining the team! Can you fixup the schema errors that were caught by pre-commit?
_data/people/dynamic-entropy.yml
Outdated
focus-area: | ||
- XrootD | ||
- FTS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check people files.......................................................Failed
- hook id: check-jsonschema
- exit code: 1
ok -- validation done
Schema validation errors were encountered.
_data/people/dynamic-entropy.yml::$.focus-area[0]: 'XrootD' is not one of ['as', 'ia', 'ssc', 'doma', 'ssl', 'osglhc', 'core']
_data/people/dynamic-entropy.yml::$.focus-area[1]: 'FTS' is not one of ['as', 'ia', 'ssc', 'doma', 'ssl', 'osglhc', 'core']
focusa-area
is supposed to map to institute focus areas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @matthewfeickert
I have addressed the changes requested in the validation check.
Cheers
@dynamic-entropy as a heads up for the future, please never make PRs from the default branch of the upstream repo. This makes it so it is impossible to rebase the PR without closing the PR and also means that you'll have to do some Git surgery later on as we squash the PRs and so your fork's default branch will now be badly out of sync with the upstream's. |
Sure, I have made a note. |
No description provided.