fix: Support Claude tool responses#3
Draft
alicemaz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, tool call response content looks like this:
with this pr, it looks like this (using
ToolChoice::toolasking claude his favorite number):I added an
Unsupportedvariant as there are several response types we don't support, most importantlytype: "thinking". if this pr is accepted, I'll also add thinking block support in a future pr when I need itif you like the enum approach, I'll fix up tests to match the new definition. if you prefer to keep the struct, I'm happy to change this pr to follow that approach instead
closes #2