Skip to content

Edited quest 2#4

Open
ChaiTeaNunes wants to merge 1 commit intoironbane:masterfrom
ChaiTeaNunes:patch-4
Open

Edited quest 2#4
ChaiTeaNunes wants to merge 1 commit intoironbane:masterfrom
ChaiTeaNunes:patch-4

Conversation

@ChaiTeaNunes
Copy link
Member

added some base code for quest 2

added some base code for quest 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since trigger is based on Unit, the "say" method is currently capitalized, .Say (js is case sensitive). also this line is missing a semi colon.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you.

On Wed, Oct 30, 2013 at 8:52 PM, Ben Sparks notifications@github.comwrote:

In scripts/triggers/halloween.js:

@@ -43,19 +43,22 @@ module.exports = {
onEnter: function(unit) {
var trigger = this;

  •        // gimme candy!
    
  •        // player drops candy
    

- // get item (pumpkin mask?)

  •        trigger.say("Trick or Treat!")
    

since trigger is based on Unit, the "say" method is currently capitalized,
.Say (js is case sensitive). also this line is missing a semi colon.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4/files#r7333535
.

@bsparks
Copy link
Member

bsparks commented Oct 31, 2013

im making so many comments in hopes to pass on some of my understanding of the game engine, hope it helps

@ChaiTeaNunes
Copy link
Member Author

It's helping a lot, some of it makes sense(but some doesn;t)

On Wed, Oct 30, 2013 at 9:10 PM, Ben Sparks notifications@github.comwrote:

im making so many comments in hopes to pass on some of my understanding of
the game engine, hope it helps


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-27460019
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants