Add helm charts #158
Merged
Add helm charts #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
hardikdr
previously approved these changes
May 12, 2025
Member
hardikdr
left a comment
hardikdr
left a comment
There was a problem hiding this comment.
Thanks for the PR @SzymonSAP .
It looks fine overall, I would wait a little in case someone else would also like to take a look.
I have not been able to test it myself, but I am assuming the charts are similarly built also for the metal-operator, and hope you have tested locally. :)
defo89
previously approved these changes
May 13, 2025
Contributor
|
We tested this in our environment and it works. If we encounter any issues, will follow up with a PR. |
hardikdr
previously approved these changes
May 13, 2025
Member
|
It looks like the merging is blocked because a "required" check is being skipped, will try to fix this later tomorrow. |
afritzler
requested changes
May 15, 2025
REUSE.toml
Outdated
|
|
||
| [[annotations]] | ||
| path = [".github/**", ".gitignore", "CODEOWNERS", "Dockerfile", "Makefile", "PROJECT", "config/**", "gen/**", "go.mod", "go.sum", "hack/**", "server/**", "templates/**", "internal/**", "cmd/**", "api/**", "config/**", "test/**", "CONTRIBUTING.md", "PROJECT", "mkdocs.yml", ".dockerignore", ".golangci.yml", "REUSE.toml"] | ||
| path = [".github/**", ".gitignore", "CODEOWNERS", "Dockerfile", "Makefile", "PROJECT", "config/**", "dist/**", "dist/**", "gen/**", "go.mod", "go.sum", "hack/**", "server/**", "templates/**", "internal/**", "cmd/**", "api/**", "config/**", "test/**", "CONTRIBUTING.md", "PROJECT", "mkdocs.yml", ".dockerignore", ".golangci.yml", "REUSE.toml"] |
Member
There was a problem hiding this comment.
Can we put this list on every line?
Member
There was a problem hiding this comment.
afritzler
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes #