Skip to content

Fix and enhance benchmark test scripts. #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

Fix and enhance benchmark test scripts. #676

merged 1 commit into from
May 19, 2025

Conversation

byteocean
Copy link
Contributor

@byteocean byteocean commented May 7, 2025

Automated benchmark testing scripts need to be adjusted to several recent enhancement of dpservice. Thus, following changes have been made to make it working:

  1. only docker-based tests for both dev and cicd (no need to run dpservice natively on hosts);
  2. use dpservice-cli in container to ensure maximum compatibility (before dpservice-cli needs to be copied into local /tmp );
  3. use google dns for VMs in any case to ensure a working apt installation in more cases where host configuration has flaws (for some reason, default dns didn't work on one of the hosts);
  4. adjust docs.

It should fix #677

1) only docker-based tests for both dev and cicd;
2) use dpservice-cli in container to ensure maximum compatibility;
3) use google dns for VMs in any case to ensure a working apt installation in more cases where host configuration has flaws;
4) adjust docs.
@github-actions github-actions bot added size/M bug Something isn't working documentation Improvements or additions to documentation labels May 7, 2025
@byteocean byteocean marked this pull request as ready for review May 7, 2025 09:30
@byteocean byteocean requested a review from a team as a code owner May 7, 2025 09:30
Copy link
Collaborator

@guvenc guvenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guvenc guvenc merged commit 9582e85 into main May 19, 2025
8 checks passed
@guvenc guvenc deleted the fix/benchmark branch May 19, 2025 11:26
@github-project-automation github-project-automation bot moved this to Done in Roadmap May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking bug Something isn't working documentation Improvements or additions to documentation size/M
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Automated benchmark tests are not compatible with enhanced dpservice
2 participants