Add S3 client interface to backupentry package to allow for better mocking#813
Merged
gonzolino merged 3 commits intoironcore-dev:mainfrom Sep 24, 2025
Merged
Conversation
This new interface allows to mock the S3 client interface in tests.
The interface is no longer needed for mocking and the functionality is integrated into the DeleteObjectsWithPrefix function.
gonzolino
force-pushed
the
backupentry-s3-mock
branch
from
7f15548 to
8d95a98
Compare
lukasfrank
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
s3ObjectListermock.s3ObjectListerinterface and integrate functionality intoDeleteObjectsWithPrefixfunction.