Do not remove the 'v' prefix from chart versions#821
Merged
gonzolino merged 2 commits intoironcore-dev:mainfrom Oct 30, 2025
Merged
Do not remove the 'v' prefix from chart versions#821gonzolino merged 2 commits intoironcore-dev:mainfrom
gonzolino merged 2 commits intoironcore-dev:mainfrom
Conversation
61644b7 to
947a999
Compare
Our non-release chart versions were using semver pre-release format (version appended by a hyphen and an identifier). This commit changes the format by appending build metadata, which uses a plus instead of a hyphen. The benefit of this change is that pre-release version identifiers must not include leading zeros, whereas build metadata can contain any ASCII alphanumerics and hyphens without further restrictions. Since we append a short git commit sha to the semver version, we can't rule out that the sha might start with a zero.
Our other artifacts, such as container images, all use the 'v' prefix for their versions. Keeping the prefix for the chart versions as well ensures taht our versioning scheme is consistent.
947a999 to
128de55
Compare
lukasfrank
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Our other artifacts, such as container images, all use the 'v' prefix
for their versions. Keeping the prefix for the chart versions as well
ensures taht our versioning scheme is consistent.