Skip to content

Do not remove the 'v' prefix from chart versions#821

Merged
gonzolino merged 2 commits intoironcore-dev:mainfrom
gonzolino:helm-version-prefix
Oct 30, 2025
Merged

Do not remove the 'v' prefix from chart versions#821
gonzolino merged 2 commits intoironcore-dev:mainfrom
gonzolino:helm-version-prefix

Conversation

@gonzolino
Copy link
Copy Markdown
Contributor

Proposed Changes

Our other artifacts, such as container images, all use the 'v' prefix
for their versions. Keeping the prefix for the chart versions as well
ensures taht our versioning scheme is consistent.

@gonzolino gonzolino requested a review from a team as a code owner October 24, 2025 11:50
@github-actions github-actions Bot added bug Something isn't working size/XS labels Oct 24, 2025
@gonzolino gonzolino force-pushed the helm-version-prefix branch from 61644b7 to 947a999 Compare October 24, 2025 11:55
@hardikdr hardikdr added the area/gardener-extension Gardener extension integration. label Oct 25, 2025
@hardikdr hardikdr added this to Roadmap Oct 25, 2025
Our non-release chart versions were using semver pre-release format
(version appended by a hyphen and an identifier). This commit changes
the format by appending build metadata, which uses a plus instead of
a hyphen.

The benefit of this change is that pre-release version identifiers must
not include leading zeros, whereas build metadata can contain any ASCII
alphanumerics and hyphens without further restrictions.

Since we append a short git commit sha to the semver version, we can't
rule out that the sha might start with a zero.
Our other artifacts, such as container images, all use the 'v' prefix
for their versions. Keeping the prefix for the chart versions as well
ensures taht our versioning scheme is consistent.
@gonzolino gonzolino force-pushed the helm-version-prefix branch from 947a999 to 128de55 Compare October 27, 2025 15:06
@github-actions github-actions Bot added size/S and removed size/XS labels Oct 27, 2025
@gonzolino gonzolino merged commit 6224eca into ironcore-dev:main Oct 30, 2025
9 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Oct 30, 2025
@gonzolino gonzolino deleted the helm-version-prefix branch November 12, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/gardener-extension Gardener extension integration. bug Something isn't working size/S

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants