Default to overlay enabled when shoot networking config is nil

[afritzler]

Summary by CodeRabbit

• Bug Fixes
  • Fixed control plane default overlay networking behavior. Overlay functionality now defaults to enabled when configuration is not explicitly provided or is incomplete, rather than defaulting to disabled. This correction ensures proper networking behavior for standard deployments without explicit overlay configuration.

[coderabbitai]

Walkthrough

The isOverlayEnabled function in the control plane values provider is modified to change its default behavior. Overlay is now considered enabled by default when networking is nil, ProviderConfig is nil, or the overlay.enabled field is missing, rather than disabled.

Changes

Cohort / File(s)	Summary
Control Plane Overlay Default Behavior pkg/controller/controlplane/valuesprovider.go	Modified the isOverlayEnabled function to return true (instead of false) when networking, ProviderConfig, or overlay.enabled field is nil/missing. Overlay is now enabled by default unless explicitly disabled via configuration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided, which fails to follow the repository's required description template with sections for 'Proposed Changes' and issue reference.	Add a pull request description following the template: include 'Proposed Changes' section explaining why overlay should default to enabled and reference the related issue number.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: defaulting overlay to enabled when shoot networking config is nil, matching the core logic change in the valuesprovider.go file.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/overlay

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}