Add BMCSettings type and controller implementation
#303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/XXL
api-change
documentation
nagadeesh-nagaraja
force-pushed
the
bmcSetting
branch
3 times, most recently
from
7a80936 to
117d5a0
Compare
afritzler
changed the title
BMCSettings type and controller implementation
nagadeesh-nagaraja
force-pushed
the
bmcSetting
branch
2 times, most recently
from
b59d95c to
6390b3f
Compare
Contributor
Author
|
Converting it back to draft as it needs a bit of update to accommodate different type of vendors and variation of settings available. |
nagadeesh-nagaraja
force-pushed
the
bmcSetting
branch
from
31c2bac to
f0eecd2
Compare
nagadeesh-nagaraja
force-pushed
the
bmcSetting
branch
from
dd1c051 to
733b885
Compare
nagadeesh-nagaraja
force-pushed
the
bmcSetting
branch
from
733b885 to
ba84abc
Compare
Contributor
Author
|
I need to do a better job with rebasing/merging with main. I messed up history again when trying to merge with main. |
afritzler
force-pushed
the
main
branch
4 times, most recently
from
0c35c73 to
0e5194a
Compare
Nuckal777
reviewed
Jun 13, 2025
Contributor
Nuckal777
left a comment
Nuckal777
left a comment
There was a problem hiding this comment.
I found some time for another review pass.
bmc/oem/dell.go
Outdated
| // for wach sub type, apply the settings | ||
| for settingPath, payload := range payloads { | ||
| // fetch the etag required for settingPath | ||
| etag, err := func(uri string) ([]string, error) { |
Contributor
There was a problem hiding this comment.
Is it possible to batch the requests instead of doing a loop? If yes, it would be a good follow-up.
Contributor
Author
There was a problem hiding this comment.
I have not tried it. server usually takes one update at a time. may be can check it out as a follow-up for sure.
afritzler
requested changes
Jun 23, 2025
* Add webhook for BMCSettings resources * remove serverRefList * Add delete logic in the webbhoob * fix some housekeeping stuff
afritzler
requested changes
Jun 24, 2025
afritzler
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #306
details #287