Add webhook for BMCSettings resources#322
Merged
afritzler merged 4 commits intobmcSettingfrom Jun 24, 2025
Merged
Conversation
github-actions
bot
added
size/XXL
documentation
nagadeesh-nagaraja
force-pushed
the
bmcSetting
branch
from
8e463ad to
5a49de7
Compare
nagadeesh-nagaraja
changed the title
bmcSetting resources
nagadeesh-nagaraja
force-pushed
the
bmcSetting
branch
from
5a49de7 to
2b35e99
Compare
nagadeesh-nagaraja
force-pushed
the
webhookBMCSetting
branch
from
68d7199 to
b321520
Compare
nagadeesh-nagaraja
force-pushed
the
bmcSetting
branch
2 times, most recently
from
8f810ed to
860e7be
Compare
nagadeesh-nagaraja
force-pushed
the
webhookBMCSetting
branch
from
b321520 to
c2d3cb3
Compare
Contributor
Author
|
need to merge after PR #303 |
nagadeesh-nagaraja
force-pushed
the
bmcSetting
branch
from
860e7be to
4a1129f
Compare
nagadeesh-nagaraja
force-pushed
the
webhookBMCSetting
branch
from
c2d3cb3 to
37d62ef
Compare
Contributor
|
Looks good in general. I guess the same comments as in #325 apply. |
nagadeesh-nagaraja
force-pushed
the
webhookBMCSetting
branch
from
37d62ef to
a3ebd83
Compare
nagadeesh-nagaraja
force-pushed
the
bmcSetting
branch
4 times, most recently
from
32cabad to
bec8d1f
Compare
nagadeesh-nagaraja
force-pushed
the
webhookBMCSetting
branch
from
a3ebd83 to
d5c98c7
Compare
nagadeesh-nagaraja
force-pushed
the
webhookBMCSetting
branch
from
d5c98c7 to
5e9abed
Compare
nagadeesh-nagaraja
force-pushed
the
bmcSetting
branch
from
bec8d1f to
6423e90
Compare
nagadeesh-nagaraja
force-pushed
the
webhookBMCSetting
branch
from
5e9abed to
e6588af
Compare
nagadeesh-nagaraja
force-pushed
the
webhookBMCSetting
branch
from
e6588af to
a95bf29
Compare
afritzler
changed the title
bmcSetting resourcesBMCSetting resources
nagadeesh-nagaraja
force-pushed
the
bmcSetting
branch
2 times, most recently
from
733b885 to
ba84abc
Compare
nagadeesh-nagaraja
force-pushed
the
webhookBMCSetting
branch
from
a95bf29 to
8a86838
Compare
Contributor
|
LGTM |
stefanhipfel
approved these changes
May 28, 2025
Nuckal777
reviewed
Jun 16, 2025
Contributor
Nuckal777
left a comment
Nuckal777
left a comment
There was a problem hiding this comment.
Thanks, looks good in general. I just got some small housekeeping stuff.
nagadeesh-nagaraja
force-pushed
the
webhookBMCSetting
branch
from
8a86838 to
98e9ecc
Compare
Nuckal777
approved these changes
Jun 23, 2025
afritzler
changed the title
BMCSetting resourcesBMCSettings resources
afritzler
approved these changes
Jun 24, 2025
afritzler
pushed a commit
that referenced
this pull request
Jun 25, 2025
* Add crd and controller for BMCSettings * change name to bmcSettings * Add reset bmc, improve controller logic * skip some lint check temporarily * Improve documentation for bmcSettings * Update design to accomodate difference vedor variations * merge conflict after rebase * request for maintenance all the time * Merge with latest Unit test helpers * expected merge changes with BIOSVersion CRD PR * Fix naming convenctions, factor out code and fix comments * Use requeAfter instead of reconcile error * Resolve merge conflicts with main * Change naming to ServerMaintenanceRefItem * resolve merge conflict with merge * regenerate genereted files * some code improvements * remove unwanted comments and newlines * Add webhook for `BMCSettings` resources (#322) * Add webhook for BMCSettings resources * remove serverRefList * Add delete logic in the webbhoob * fix some housekeeping stuff * Update the serverMaintenanceRef API field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #307