Factor out common test helpers into own file and remove flakiness #336
Merged
Factor out common test helpers into own file and remove flakiness #336
Conversation
nagadeesh-nagaraja
force-pushed
the
testHelpers
branch
from
0fa3ab9 to
bca6613
Compare
nagadeesh-nagaraja
force-pushed
the
testHelpers
branch
from
bca6613 to
5ae6405
Compare
nagadeesh-nagaraja
force-pushed
the
testHelpers
branch
from
57b5b8a to
838221f
Compare
nagadeesh-nagaraja
force-pushed
the
testHelpers
branch
from
838221f to
765241f
Compare
nagadeesh-nagaraja
requested review from
Nuckal777,
afritzler and
stefanhipfel
and removed request for
afritzler and
stefanhipfel
nagadeesh-nagaraja
force-pushed
the
testHelpers
branch
3 times, most recently
from
e4e4723 to
403cf39
Compare
Nuckal777
reviewed
May 21, 2025
nagadeesh-nagaraja
force-pushed
the
testHelpers
branch
from
403cf39 to
9012e69
Compare
Nuckal777
reviewed
May 22, 2025
Contributor
Nuckal777
left a comment
Nuckal777
left a comment
There was a problem hiding this comment.
Thanks, looks good in general. 👍 I just got a few smaller remarks.
nagadeesh-nagaraja
force-pushed
the
testHelpers
branch
from
9012e69 to
e141842
Compare
Closed
afritzler
requested changes
May 22, 2025
afritzler
changed the title
nagadeesh-nagaraja
changed the title
nagadeesh-nagaraja
changed the title
Nuckal777
approved these changes
May 22, 2025
afritzler
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create helper functions for server creation and transitioning to Available and Reserved state
fix the Patch call we make to mockup as it was patching RawData received which was causing redfish Mockup overlaod.