Move Server.Status popolation from ServerReconciler to BMCReconciler
#339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afritzler
requested changes
May 22, 2025
afritzler
changed the title
Server.Status popolation from ServerReconciler to BMCReconciler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
BMC controller now loads Server Status Details (Manufacturer, Storages, CPUs) once during creation of a server CRD and when setting the anntotation
"metal.ironcore.dev/operation" : "update-server-details".BMC controller reconcile loop now only gets called when server was deleted or ops annotation was set.
Fixes:
Redfish Processors are now called separately, only when needed.
In General: Less calls to BMC redfish api
Server Controller Test:
Before: 700 API calls
After: 305 API calls