Add BMCSettingsApplyResultEntry type to BMCSettings status for ETag-based drift detection

[atd9876]

Add the BMCSettingsApplyResultEntry struct to api/v1alpha1/bmcsettings_types.go and the AppliedETags field to BMCSettingsStatus:

type BMCSettingsApplyResultEntry struct {
URI string json:"uri,omitempty"
ETag string json:"etag,omitempty"
ValueHash string json:"valueHash,omitempty"
}

AppliedETags map[string]BMCSettingsApplyResultEntry json:"appliedETags,omitempty"

• URI: the Redfish resource URI from the apply response (Location header for POST-created resources; request URI for PATCH)
• ETag: drift-detection token after the last successful apply — either a real ETag returned by the BMC (e.g. W/"20B77DA6") or a SHA-256 hash of the GET response prefixed with "hash:sha256:" for BMCs that do not return ETag headers
• ValueHash: SHA-256 of the effective (resolved) value at apply time, used to detect desired-state changes from ConfigMap/Secret rotation without relying on metadata.generation

The type is named BMCSettingsApplyResultEntry (rather than ApplyResultEntry) to follow the existing sub-type naming convention (BMCSettingsSpec, BMCSettingsStatus, BMCSettingsSetStatus, etc.) and to scope it clearly to the BMCSettings resource.

Regenerate CRD manifests and deepcopy/applyconfiguration code via make manifests generate. No controller logic changes in this commit.

Fixes #915
Part of #858

Summary by CodeRabbit

• New Features

  • BMC settings status now records per-setting apply results, including the Redfish URI, ETag, and resolved value hash.
  • Added support for tracking configuration changes and detecting drift during verification, including SHA-256 hash fallbacks where needed.
  • Extended configuration and resource schemas to expose this apply-result metadata.

• Documentation

  • Updated the API reference with the new apply-result type and status field.

[coderabbitai]

Warning

Review limit reached

@atd9876, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cd8ab5b4-49b0-4665-abcf-db8a459eb1b9

📥 Commits

Reviewing files that changed from the base of the PR and between 5db0319 and 5a4095b.

⛔ Files ignored due to path filters (1)

• dist/chart/templates/crd/metal.ironcore.dev_bmcsettings.yaml is excluded by !**/dist/**

📒 Files selected for processing (8)

• api/v1alpha1/applyconfiguration/api/v1alpha1/bmcsettingsapplyresultentry.go
• api/v1alpha1/applyconfiguration/api/v1alpha1/bmcsettingsstatus.go
• api/v1alpha1/applyconfiguration/internal/internal.go
• api/v1alpha1/applyconfiguration/utils.go
• api/v1alpha1/bmcsettings_types.go
• api/v1alpha1/zz_generated.deepcopy.go
• config/crd/bases/metal.ironcore.dev_bmcsettings.yaml
• docs/api-reference/api.md

📝 Walkthrough

Walkthrough

BMCSettings status now stores per-key Redfish URI, ETag, and resolved-value hash metadata. Generated apply configurations, schemas, deep-copy support, CRD definitions, and API documentation were updated accordingly.

Changes

BMCSettings apply-result metadata

Layer / File(s)	Summary
BMCSettings status API contract api/v1alpha1/bmcsettings_types.go	Adds AppliedETags and the BMCSettingsApplyResultEntry type containing URI, ETag, and value-hash fields.
Apply-configuration and schema wiring api/v1alpha1/applyconfiguration/api/v1alpha1/..., api/v1alpha1/applyconfiguration/internal/internal.go, api/v1alpha1/applyconfiguration/utils.go	Adds fluent apply-configuration builders, structured-merge schema entries, and ForKind support for apply-result entries.
Generated artifacts and documentation api/v1alpha1/zz_generated.deepcopy.go, config/crd/bases/metal.ironcore.dev_bmcsettings.yaml, docs/api-reference/api.md	Adds deep-copy handling, CRD schema definitions, and API reference documentation for appliedETags.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

• #914 — Adds persisted per-setting apply results used for drift detection.
• #919 — Adds API and schema support for controller-stored drift-detection data.
• #917 — Defines the AppliedETags structures consumed by drift detection.
• #916 — Adds the status model for URI, ETag, and value-hash apply results.

Suggested labels: enhancement, area/metal-automation

Suggested reviewers: afritzler, xkonni, stefanhipfel

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: adding the BMCSettingsApplyResultEntry type for ETag-based drift detection.
Description check	✅ Passed	The description covers the new type, AppliedETags field, field semantics, regeneration step, and links the fix as required.
Linked Issues check	✅ Passed	The PR implements #915’s requested status field, entry struct, and generated CRD/deepcopy/applyconfiguration updates.
Out of Scope Changes check	✅ Passed	The changes stay focused on the API type addition and generated artifacts, with no unrelated functional changes evident.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@api/v1alpha1/bmcsettings_types.go`:
- Around line 177-178: Update the AppliedETags documentation comment to state
that it stores the URI, ETag, and ValueHash from the last successful apply for
each settings key, while retaining the existing drift-detection context.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3a58f8bc-6b59-49ec-806c-99ee92591046

📥 Commits

Reviewing files that changed from the base of the PR and between e0b34f0 and 5db0319.

⛔ Files ignored due to path filters (1)

• dist/chart/templates/crd/metal.ironcore.dev_bmcsettings.yaml is excluded by !**/dist/**

📒 Files selected for processing (8)

• api/v1alpha1/applyconfiguration/api/v1alpha1/bmcsettingsapplyresultentry.go
• api/v1alpha1/applyconfiguration/api/v1alpha1/bmcsettingsstatus.go
• api/v1alpha1/applyconfiguration/internal/internal.go
• api/v1alpha1/applyconfiguration/utils.go
• api/v1alpha1/bmcsettings_types.go
• api/v1alpha1/zz_generated.deepcopy.go
• config/crd/bases/metal.ironcore.dev_bmcsettings.yaml
• docs/api-reference/api.md