feat: lower validation decorators to ordinary JavaScript - #4
Draft
irvinebroque wants to merge 2 commits into
Draft
feat: lower validation decorators to ordinary JavaScript#4irvinebroque wants to merge 2 commits into
irvinebroque wants to merge 2 commits into
Conversation
|
I have read the CLA Document and I hereby sign the CLA Brendan Irvine-Broque seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@validateRpc()tells our build step to add checks to a class. Today, that step leaves a decorator in its output, so the next build tool still needs decorator support. This causes trouble with toolchains such as Vite 8/Oxc.The transform now removes its markers and makes an ordinary function call after the class declaration. It updates the existing prototype without replacing the class. Named default exports, private fields, inheritance, and static initialization keep working. All recognized skip markers are removed too.
Anonymous classes need names; repeated validation class markers and other class decorators together with
@validateRpcproduce build errors. The README, validation guide, and minor changeset explain migration.Validation: 621 Node and Workers tests, build, type checks, and Markdown lint pass.
Upstream #231 tackles the same build-tool problem with different source syntax. Coordinate these approaches before upstreaming.