Skip to content

feat: lower validation decorators to ordinary JavaScript - #4

Draft
irvinebroque wants to merge 2 commits into
mainfrom
codex/lower-validation-decorators
Draft

feat: lower validation decorators to ordinary JavaScript#4
irvinebroque wants to merge 2 commits into
mainfrom
codex/lower-validation-decorators

Conversation

@irvinebroque

@irvinebroque irvinebroque commented Sep 5, 2026

Copy link
Copy Markdown
Owner

@validateRpc() tells our build step to add checks to a class. Today, that step leaves a decorator in its output, so the next build tool still needs decorator support. This causes trouble with toolchains such as Vite 8/Oxc.

The transform now removes its markers and makes an ordinary function call after the class declaration. It updates the existing prototype without replacing the class. Named default exports, private fields, inheritance, and static initialization keep working. All recognized skip markers are removed too.

Anonymous classes need names; repeated validation class markers and other class decorators together with @validateRpc produce build errors. The README, validation guide, and minor changeset explain migration.

Validation: 621 Node and Workers tests, build, type checks, and Markdown lint pass.

Upstream #231 tackles the same build-tool problem with different source syntax. Coordinate these approaches before upstreaming.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


Brendan Irvine-Broque seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant