Skip to content

fix MC-268617#439

Merged
isXander merged 2 commits into
isXander:1.21.7from
MicrocontrollersDev:mc-268617
Jul 20, 2025
Merged

fix MC-268617#439
isXander merged 2 commits into
isXander:1.21.7from
MicrocontrollersDev:mc-268617

Conversation

@MicrocontrollersDev

Copy link
Copy Markdown
Contributor

@isXander isXander left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A JavaDoc explaining what this actually does to fix would be nice, as well as a fix explanation maybe?

@MicrocontrollersDev

Copy link
Copy Markdown
Contributor Author

added javadoc, tho honestly I myself know next to nothing about this (wtf is ¹²³). gravy requested I PR a fix for this, and he further explained

the one in the comments was me and telepathicgrunt going back and forth with other people trying to think of one thatll match all of the reserved names because microsoft straight up doesnt document some of those 😭

@isXander isXander merged commit e5d4785 into isXander:1.21.7 Jul 20, 2025
1 check passed
@MicrocontrollersDev MicrocontrollersDev deleted the mc-268617 branch July 20, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants