Revision of STR methods in measures#24
Open
Alegomcab1 wants to merge 3 commits into
Open
Conversation
Added new test cases and STR representation for business duration
resinas
requested changes
Jan 25, 2022
resinas
left a comment
resinas
left a comment
Member
There was a problem hiding this comment.
There are two things that are not supported yet in the generation:
- It does not work well when the aggregation function is defined using lowercase instead of uppercase. For instance:
model.AggregatedMeasure(model.CountMeasure("concept:name=='Appeal to Judge'"), 'avg') - It does not work well when the condition is defined as a TimeInstantCondition like:
model.CountMeasure(model.TimeInstantCondition(model.RuntimeState.START, model.AppliesTo.ACTIVITY, "Appeal to Judge"))
| from .conditions import TimeInstantCondition | ||
| import datetime | ||
| import calendar | ||
| import holidays as pyholidays |
Member
There was a problem hiding this comment.
I don't think this dependency is necessary here. Holidays are provided by the user as a list to BusinessDuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new test cases and STR representation for business duration