Skip to content

Commit 7257bc9

Browse files
authored
Remove flatdict dependency (#6547)
# Description Remove the unused `flatdict` dependency from the root test extra and the two CI bootstrap commands that install test tooling. Also remove `flatdict` from the Sphinx mocked-import list. The repository no longer imports or otherwise uses `flatdict`, so retaining it adds unnecessary installation and dependency-resolution work. Dependencies required by this change: none. This change removes `flatdict`. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Screenshots Not applicable. ## Validation - `./isaaclab.sh -p -m pytest source/isaaclab/test/cli/test_uv_run_pyproject.py` (6 passed) - `bash -n .github/actions/multi-gpu/multi_gpu_shard_runner.sh` - Parsed `pyproject.toml` and asserted the test extra contains no `flatdict` requirement - Searched the repository for remaining live `flatdict` references; only the historical changelog entry remains - `./isaaclab.sh -f` (passed before commit and again before push) ## Checklist - [x] I have read and understood the contribution guidelines - [x] I have run the pre-commit checks with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works (no new test was needed for this metadata-only removal; existing metadata tests pass) - [x] I have added a changelog fragment for every touched package (not applicable; no package under `source/` was changed) - [x] My name already exists in `CONTRIBUTORS.md`
1 parent 03904ab commit 7257bc9

4 files changed

Lines changed: 2 additions & 4 deletions

File tree

.github/actions/multi-gpu/multi_gpu_shard_runner.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ mkdir -p /tmp/mgpu-base-home /tmp/mgpu-pyuserbase
4949

5050
# Pytest deps (same as run-tests action). junitparser is imported at
5151
# tools/conftest.py load time, so it must be present first.
52-
./isaaclab.sh -p -m pip install pytest pytest-mock junitparser flatdict flaky "coverage>=7.6.1"
52+
./isaaclab.sh -p -m pip install pytest pytest-mock junitparser flaky "coverage>=7.6.1"
5353

5454
# Shard count from nvidia-smi -L (truth; torch under-counts MIG).
5555
MIG_COUNT=$(nvidia-smi -L | grep -c "^ MIG ") # grep -c = count of matching lines (MIG slices)

.github/actions/run-tests/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ runs:
396396
# set this detect-only flag, which makes cold asset downloads
397397
# fall back to slow repeated retries.
398398
unset HUB__ARGS__DETECT_ONLY
399-
./isaaclab.sh -p -m pip install pytest pytest-mock junitparser flatdict flaky \"coverage>=7.6.1\"
399+
./isaaclab.sh -p -m pip install pytest pytest-mock junitparser flaky \"coverage>=7.6.1\"
400400
if [ -n \"\${TEST_WHEELHOUSE_PACKAGES:-}\" ]; then
401401
if [ ! -d \"\${TEST_WHEELHOUSE_PATH:-}\" ]; then
402402
echo \"Wheelhouse path is missing: \${TEST_WHEELHOUSE_PATH:-}\"

docs/conf.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,6 @@ def _read_pinned_versions() -> dict:
266266
"pink",
267267
"pinocchio",
268268
"qpsolvers",
269-
"flatdict",
270269
"filelock",
271270
"IPython",
272271
"cv2",

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ test = [
9999
"pytest",
100100
"pytest-mock",
101101
"junitparser",
102-
"flatdict>=4.1.0",
103102
"flaky",
104103
# numba subclasses coverage.types.Tracer at import; >=7.6.1 restores that shim
105104
"coverage>=7.6.1",

0 commit comments

Comments
 (0)