Skip to content

Commit 8ccabde

Browse files
authored
Cherry-pick for fix Rlinf config path (#6138)
# Description <!-- Thank you for your interest in sending a pull request. Please make sure to check the contribution guidelines. Link: https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html 💡 Please try to keep PRs small and focused. Large PRs are harder to review and merge. --> Fixes path of RLinf config yaml file caused by missing path resolver. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. --> ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
1 parent ddb0073 commit 8ccabde

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

scripts/reinforcement_learning/rlinf/play_rlinf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@
5757
# Resolve config path and name from CLI args
5858
if not args_cli.config_name:
5959
parser.error("--config_name is required (e.g. --config_name isaaclab_ppo_gr00t_assemble_trocar)")
60-
config_dir = args_cli.config_path or str(SCRIPT_DIR)
6160
config_name = args_cli.config_name
61+
config_dir = cli_args.resolve_config_dir(config_name, args_cli.config_path)
6262
os.environ["RLINF_CONFIG_FILE"] = str(Path(config_dir) / f"{config_name}.yaml")
6363

6464
# Add config dir to PYTHONPATH so that Ray rollout workers can resolve

scripts/reinforcement_learning/rlinf/train_rlinf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ def run(argv: list[str]) -> None:
7070
_list_tasks()
7171
return
7272

73-
config_dir = args_cli.config_path or str(RLINF_DIR)
7473
config_name = args_cli.config_name
74+
config_dir = CLI_ARGS.resolve_config_dir(config_name, args_cli.config_path)
7575
os.environ["RLINF_CONFIG_FILE"] = str(Path(config_dir) / f"{config_name}.yaml")
7676

7777
if config_dir not in os.environ.get("PYTHONPATH", ""):

0 commit comments

Comments
 (0)