Skip to content

Commit 99af9e5

Browse files
committed
Fix stale single-source references for dependency pins
The root pyproject.toml is the single source of truth for dependency pins, but three references to it have gone stale: - The wheel-builder comment referenced python_packages.toml, a manifest that no longer exists. - daily-compatibility.yml parsed [tool.isaaclab.versions] with a hand written regex; use tomllib for the same output with real TOML parsing. - The pip-installation docs claimed rl_games is not included in the wheel extras, but gen_pyproject.py expands the all extra with rl-games (from the isaac-sim git branch) along with Rerun, Mimic, and RLinf.
1 parent 556e431 commit 99af9e5

3 files changed

Lines changed: 9 additions & 11 deletions

File tree

.github/workflows/daily-compatibility.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,9 @@ jobs:
117117
id: ov_pins
118118
run: |
119119
PINS=$(python3 <<'PY'
120-
import re
121-
block = re.search(r"^\[tool\.isaaclab\.versions\]\n(.*?)(?:\n\[|\Z)", open("pyproject.toml").read(), re.S | re.M).group(1)
122-
vals = dict(re.findall(r'(\w+)\s*=\s*"([^"]+)"', block))
120+
import tomllib
121+
with open("pyproject.toml", "rb") as f:
122+
vals = tomllib.load(f)["tool"]["isaaclab"]["versions"]
123123
print(f"ovphysx=={vals['ovphysx']} ovrtx{vals['ovrtx']}")
124124
PY
125125
)

docs/source/setup/installation/isaaclab_pip_installation.rst

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ pip extras include:
3232
* - ``isaacsim``
3333
- Isaac Sim (``isaacsim[all,extscache]`` version |isaacsim_version|) from `pypi.nvidia.com <https://pypi.nvidia.com>`_
3434
* - ``all``
35-
- RL frameworks (SB3, SKRL, RSL-RL). Combine with ``isaacsim`` for a full install.
35+
- RL frameworks (SB3, SKRL, RSL-RL, RL-Games), the Rerun visualizer, Mimic, and
36+
RLinf post-training. Combine with ``isaacsim`` for a full install.
3637

3738
Install with ``isaaclab[isaacsim,all]`` for the full workflow.
3839

@@ -52,12 +53,9 @@ Install with ``isaaclab[isaacsim,all]`` for the full workflow.
5253
5354
.. note::
5455

55-
``rl_games`` is not included in the Isaac Lab pip wheel extras. If your workflow requires
56-
``rl_games``, install it manually from the Isaac Lab-compatible branch:
57-
58-
.. code-block:: bash
59-
60-
pip install "rl-games @ git+https://github.com/isaac-sim/rl_games.git@python3.11" gym standard-distutils
56+
``rl_games`` is installed by the ``all`` (or ``rl-games``) extra directly from the
57+
Isaac Lab-compatible git branch (``isaac-sim/rl_games@python3.11``), so ``git`` must
58+
be available on the machine at install time.
6159

6260
Installing dependencies
6361
~~~~~~~~~~~~~~~~~~~~~~~

tools/wheel_builder/build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ esac
3737
rm -rf "$BUILD_DIR" "$DIST_DIR"
3838
mkdir -p "$BUILD_DIR/src/isaaclab"
3939

40-
# 1. Copy inventory (same as python_packages.toml inventory.includes.all)
40+
# 1. Copy inventory (the full source tree: apps/ + source/)
4141
cp -r apps "$BUILD_DIR/src/isaaclab/"
4242
cp -r source "$BUILD_DIR/src/isaaclab/"
4343

0 commit comments

Comments
 (0)