Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds Xcode selection configuration to four CI jobs running on macOS 26 runners. The changes attempt to ensure a specific Xcode version (26.0) is used during CI execution by setting the DEVELOPER_DIR environment variable and running xcode-select commands.
- Adds DEVELOPER_DIR environment variable pointing to Xcode 26.0
- Adds explicit Xcode selection step using xcode-select before running tests
- Applies changes consistently across quicktest-macos, unit-test-macos, build-macos, and perf-test-macos jobs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Select Xcode 26 | ||
| run: | | ||
| sudo xcode-select -s /Applications/Xcode_26.0.app | ||
| xcodebuild -version |
There was a problem hiding this comment.
The DEVELOPER_DIR environment variable points to /Applications/Xcode_26.0.app/Contents/Developer, but the xcode-select command uses /Applications/Xcode_26.0.app (without /Contents/Developer). These should be consistent - xcode-select expects the path to the .app bundle, while DEVELOPER_DIR should point to the Developer directory. However, since DEVELOPER_DIR is already set correctly, the xcode-select path should also include /Contents/Developer or the DEVELOPER_DIR setting makes the xcode-select call redundant.
| - name: Select Xcode 26 | ||
| run: | | ||
| sudo xcode-select -s /Applications/Xcode_26.0.app | ||
| xcodebuild -version |
There was a problem hiding this comment.
The DEVELOPER_DIR environment variable points to /Applications/Xcode_26.0.app/Contents/Developer, but the xcode-select command uses /Applications/Xcode_26.0.app (without /Contents/Developer). These should be consistent - xcode-select expects the path to the .app bundle, while DEVELOPER_DIR should point to the Developer directory. However, since DEVELOPER_DIR is already set correctly, the xcode-select path should also include /Contents/Developer or the DEVELOPER_DIR setting makes the xcode-select call redundant.
| - name: Select Xcode 26 | ||
| run: | | ||
| sudo xcode-select -s /Applications/Xcode_26.0.app | ||
| xcodebuild -version |
There was a problem hiding this comment.
The DEVELOPER_DIR environment variable points to /Applications/Xcode_26.0.app/Contents/Developer, but the xcode-select command uses /Applications/Xcode_26.0.app (without /Contents/Developer). These should be consistent - xcode-select expects the path to the .app bundle, while DEVELOPER_DIR should point to the Developer directory. However, since DEVELOPER_DIR is already set correctly, the xcode-select path should also include /Contents/Developer or the DEVELOPER_DIR setting makes the xcode-select call redundant.
| - name: Select Xcode 26 | ||
| run: | | ||
| sudo xcode-select -s /Applications/Xcode_26.0.app | ||
| xcodebuild -version |
There was a problem hiding this comment.
The DEVELOPER_DIR environment variable points to /Applications/Xcode_26.0.app/Contents/Developer, but the xcode-select command uses /Applications/Xcode_26.0.app (without /Contents/Developer). These should be consistent - xcode-select expects the path to the .app bundle, while DEVELOPER_DIR should point to the Developer directory. However, since DEVELOPER_DIR is already set correctly, the xcode-select path should also include /Contents/Developer or the DEVELOPER_DIR setting makes the xcode-select call redundant.
No description provided.