Skip to content

Update some versions and installation instructions#12

Open
jessesnyder wants to merge 1 commit into
masterfrom
update-2022
Open

Update some versions and installation instructions#12
jessesnyder wants to merge 1 commit into
masterfrom
update-2022

Conversation

@jessesnyder
Copy link
Copy Markdown

@jessesnyder jessesnyder commented Mar 23, 2022

Not sure if the python-ldap update is necessary, tbh.

@jessesnyder jessesnyder requested a review from paregorios March 23, 2022 00:35
Copy link
Copy Markdown
Member

@paregorios paregorios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to me like what was discussed in slack yesterday. I'm not currently equipped to test locally, so perhaps we should have another developer with a working dev environment also test?

Copy link
Copy Markdown

@alecpm alecpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The version pins mostly duplicate the changes from 8daafa1 which I merged to staging earlier, but that's no big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants