chore: update google map link #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-added staff scan qr page
added staff-qr page
- Fixed Staff-qr handling error - Fix error type assertions in staff/event/index.astro - Remove unused imports and variables
…/fdrpkm68-frontend into feat/firstdate/staff-qr
- Added auth functions getAuthToken() and getAuthHeaders() in api.ts - Fixed body stream error when scan qr code - Added handle error when user is not exist and when user scan wrong qr
- fix ButtonFd not send data
- Fixed no events active layout
…/fdrpkm68-frontend into feat/firstdate/staff-qr
* feat: added staff scan qr page -added staff scan qr page * fix: firstdate staff bg * feat: add @yudiel/react-qr-scanner * Feat: added staff-qr page added staff-qr page * chore: fix middleware doesn't work * feat: Implement qr scan with api * fix: staff-qr code - Fixed Staff-qr handling error - Fix error type assertions in staff/event/index.astro - Remove unused imports and variables * fix: qr scan error, body stream err, cannot send cookie to backend err - Added auth functions getAuthToken() and getAuthHeaders() in api.ts - Fixed body stream error when scan qr code - Added handle error when user is not exist and when user scan wrong qr * Fix: alternative form handle error - fix ButtonFd not send data * fix: no event active layout - Fixed no events active layout * fix: qrcode --------- Co-authored-by: neennera <[email protected]> Co-authored-by: Thukdanai Thaothawin <[email protected]> Co-authored-by: Borworntat Dendumrongkul <[email protected]>
[Feature][RPKM] Workshop integrate backend
[Feat][Firstdate] Add FM Night menu
[Fix][Firstdate] Changed background to webp
[Feature][RPKM] Workshop & styling minor
[Feature][RPKM] intagrate bottle of choice
There was a problem hiding this comment.
Pull Request Overview
This PR updates Google Maps links and improves error message handling for workshop registration. The changes focus on providing better user experience through updated location links and more descriptive error messages in Thai.
- Updated Google Maps links for two shop locations in the quest2-shops data file
- Enhanced error message handling in WorkshopCard component to provide specific Thai error messages based on different registration failure scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/data/fest/quest2-shops.ts | Updates Google Maps URLs for two shop entries |
| src/components/rpkm/workshop/WorkshopCard.tsx | Replaces generic error message with specific Thai error messages based on error content |
Comments suppressed due to low confidence (2)
src/components/rpkm/workshop/WorkshopCard.tsx:40
- [nitpick] The variable name 'msg' is too abbreviated and unclear. Consider renaming it to 'errorMessage' or 'responseError' for better readability.
const msg = response.error || "";
src/components/rpkm/workshop/WorkshopCard.tsx:41
- [nitpick] The variable name 'errMsg' is abbreviated and inconsistent with TypeScript naming conventions. Consider renaming it to 'errorMessage' to be more descriptive and consistent.
let errMsg: string;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.