[Feature] [Firstdate] register / login page #14

RuffLogix · 2025-07-08T12:19:28Z

No description provided.

Copilot

Pull Request Overview

Adds the Firstdate registration and login flows, server-side health endpoint, global font imports, new layout components, and performance-testing UI on the home page.

Import IBM Plex Sans Thai and Zen Dots fonts in global CSS
Enhance index.astro with backend health check, 8K image load timing, and performance info panel
Scaffold /firstdate pages with staff/user register & login forms and updated layouts

Reviewed Changes

Copilot reviewed 41 out of 65 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/styles/global.css	Added custom font imports & body font-family
src/pages/index.astro	Integrated API health check & 8K backdrop + performance UI
src/pages/api/health.ts	New `/api/health` route for status & responseTime
src/pages/firstdate/**	Created register/login pages for staff & users
src/layouts/MainLayout.astro	Switched to English `<html lang>`, added Header & Footer
src/components/common/Navbar.astro	Mobile menu always hidden due to incorrect classes
src/components/firstdate/Footer.astro	Stray closing `</a>` before Website link

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Comments suppressed due to low confidence (3)

src/layouts/firstdate/WithoutNavbar.astro:3

The Navbar import isn’t used in this layout; consider removing it to reduce clutter.

import Navbar from "@firstdate/Navbar.astro";

src/pages/index.astro:156

The newly created apiLoadTimeElement is never appended or used; you can remove this unused variable.

  const apiLoadTimeElement = document.createElement('span');

src/components/firstdate/Footer.astro:48

There’s a stray closing </a> tag before the Website link; remove the extra tag to fix the HTML structure.

        </a>

Copilot · 2025-07-08T12:23:17Z

src/layouts/firstdate/WithoutNavbar.astro

+    <main class="flex-grow">
+      <slot />
+    </main>
+    <Footer varient="firstdate"/>


The prop varient appears to be a misspelling of variant; renaming it will improve clarity.

Suggested change

<Footer varient="firstdate"/>

<Footer variant="firstdate"/>

Copilot · 2025-07-08T12:23:18Z

src/pages/index.astro

+    fetch('https://dev.freshmenfest2025.com/api/health')
+      .then(() => {
+        const apiPerfEntries = performance.getEntriesByName('https://dev.freshmenfest2025.com/api/health');


Hardcoding the full dev URL makes this feature environment-specific; consider using a relative path (/api/health) or location.origin for flexibility.

Suggested change

fetch('https://dev.freshmenfest2025.com/api/health')

.then(() => {

const apiPerfEntries = performance.getEntriesByName('https://dev.freshmenfest2025.com/api/health');

const apiHealthUrl = `${location.origin}/api/health`;

fetch(apiHealthUrl)

.then(() => {

const apiPerfEntries = performance.getEntriesByName(apiHealthUrl);

Copilot · 2025-07-08T12:23:18Z

src/pages/firstdate/home/index.astro

+      <div class="flex w-full justify-center">
+        <div class="flex flex-col w-4/5 gap-y-2 my-3">
+          <DummyButton href="/firstdate/home/">
+            <img src="/firstdate/home/qrcode.svg"> QR CODE


This <img> tag lacks an alt attribute; please add meaningful alt text (e.g. alt="QR Code for CU First Date").

Suggested change

<img src="/firstdate/home/qrcode.svg"> QR CODE

<img src="/firstdate/home/qrcode.svg" alt="QR Code for CU First Date"> QR CODE

Copilot · 2025-07-08T12:23:19Z

src/pages/about.astro

+
+      <div class="text-center">
+        <a 
+          href="/register" 


The link points to /register, but the registration page is at /firstdate/register; update the href to match the actual route.

Suggested change

href="/register"

href="/firstdate/register"

Copilot · 2025-07-08T12:23:19Z

src/components/firstdate/ui/staff/RegisterForm.tsx

+                <label htmlFor="">อาหารที่แพ้</label>
+                <div className="flex gap-2 justify-between w-full px-12">
+                    <div className="flex items-center gap-2">
+                        <input 
+                            type="checkbox" 
+                            className="w-4 h-4" 
+                            checked={healthInfo.hasAllergies === true}
+                            onChange={() => handleAllergiesChange(true)} 
+                        />
+                        <label htmlFor="">มี</label>
+                    </div>
+                    <div className="flex items-center gap-2">
+                        <input 
+                            type="checkbox" 
+                            className="w-4 h-4" 
+                            checked={healthInfo.hasAllergies === false}
+                            onChange={() => handleAllergiesChange(false)} 
+                        />
+                        <label htmlFor="">ไม่มี</label>
+                    </div>
+                </div>


Labels use an empty htmlFor and inputs lack id attributes, which hinders screen-reader association; assign matching id/htmlFor values.

Suggested change

<label htmlFor="">อาหารที่แพ้</label>

<div className="flex gap-2 justify-between w-full px-12">

<div className="flex items-center gap-2">

<input

type="checkbox"

className="w-4 h-4"

checked={healthInfo.hasAllergies === true}

onChange={() => handleAllergiesChange(true)}

/>

<label htmlFor="">มี</label>

</div>

<div className="flex items-center gap-2">

<input

type="checkbox"

className="w-4 h-4"

checked={healthInfo.hasAllergies === false}

onChange={() => handleAllergiesChange(false)}

/>

<label htmlFor="">ไม่มี</label>

</div>

</div>

<label htmlFor="allergies">อาหารที่แพ้</label>

<div className="flex gap-2 justify-between w-full px-12">

<div className="flex items-center gap-2">

<input

type="checkbox"

className="w-4 h-4"

id="allergies-yes"

checked={healthInfo.hasAllergies === true}

onChange={() => handleAllergiesChange(true)}

/>

<label htmlFor="allergies-yes">มี</label>

</div>

<div className="flex items-center gap-2">

<input

type="checkbox"

className="w-4 h-4"

id="allergies-no"

checked={healthInfo.hasAllergies === false}

onChange={() => handleAllergiesChange(false)}

/>

<label htmlFor="allergies-no">ไม่มี</label>

</div>

MasterIceZ · 2025-07-13T12:39:52Z

src/components/common/login/ForgetPasswordStep.tsx

+  setValue: UseFormSetValue<LoginFormData>;
+  onSubmit: (e?: React.BaseSyntheticEvent) => Promise<void>;
+  onBack?: () => void;
+  userType: "student" | "staff";


Suggested change

userType: "student" | "staff";

userType: "FRESHMAN" | "STAFF";

@MasterIceZ done kub

feat: login & register page

5cefe8b

Copilot AI review requested due to automatic review settings July 8, 2025 12:19

RuffLogix changed the base branch from main to dev July 8, 2025 12:19

Copilot AI reviewed Jul 8, 2025

View reviewed changes

RuffLogix added 2 commits July 8, 2025 19:31

fix: add id and htmlFor

43351f3

fix: remove pdpa consent form from login page

be49928

RuffLogix changed the title ~~Feat/firstdate/register~~ [Feature] [FD] register / login page Jul 12, 2025

RuffLogix added 8 commits July 12, 2025 17:20

Merge dev

d2516ac

refactor: login and register components

c2bcddf

fix: input field format

172ff56

fix: design input button

d0a4d84

fix: pdpa gradient color

8211fd3

fix: button style

3b9326d

fix: validate form

f43807b

feat: success page

562ae30

RuffLogix requested review from MasterIceZ, dhanavadh and neennera July 12, 2025 17:04

RuffLogix changed the title ~~[Feature] [FD] register / login page~~ [Feature] [Firstdate] register / login page Jul 12, 2025

RuffLogix added 8 commits July 13, 2025 13:47

fix: apply react-hook-form

17dc371

Merge dev

34ce09f

fix: lint

530bb54

fix: lint

12273df

fix: lint

bb16ff8

fix: lint

a4c131c

fix: lint

80b8608

fix: lint

23b128f

MasterIceZ requested changes Jul 13, 2025

View reviewed changes

fix: userType enum

9d6de99

MasterIceZ approved these changes Jul 13, 2025

View reviewed changes

MasterIceZ merged commit daa2cfc into dev Jul 13, 2025
7 checks passed

MasterIceZ deleted the feat/firstdate/register branch July 13, 2025 13:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[Feature] [Firstdate] register / login page #14

[Feature] [Firstdate] register / login page #14

Uh oh!

RuffLogix commented Jul 8, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 8, 2025

Uh oh!

Copilot AI Jul 8, 2025

Uh oh!

Copilot AI Jul 8, 2025

Uh oh!

Copilot AI Jul 8, 2025

Uh oh!

Copilot AI Jul 8, 2025

Uh oh!

MasterIceZ Jul 13, 2025

Uh oh!

RuffLogix Jul 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	<img src="/firstdate/home/qrcode.svg"> QR CODE
	<img src="/firstdate/home/qrcode.svg" alt="QR Code for CU First Date"> QR CODE

	userType: "student" \| "staff";
	userType: "FRESHMAN" \| "STAFF";

Uh oh!

[Feature] [Firstdate] register / login page #14

[Feature] [Firstdate] register / login page #14

Uh oh!

Conversation

RuffLogix commented Jul 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

MasterIceZ Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

RuffLogix Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants