Skip to content

Conversation

@dhanavadh
Copy link
Contributor

Summary

  • this fix is due to the popup component is fixed by itself and cannot bypass by class.
  • fix children overflow from parent component
  • this error makes Popup component arranged in wrong way and hard to implement
  • styling by class

Example

you can implement class within class. for example, class="flex flex-col items-center justify-center text-center"

<Popup
    size="large"   
    color="vivid-pink"                                     
    class="flex flex-col items-center justify-center text-center"
>
    <p class="text-lg text-white">หากคุณพบเหตุฉุกเฉินหรือมีความต้องการความช่วยเหลือด่วน กรุณาติดต่อหน่วยงานที่เกี่ยวข้องตามข้อมูลด้านล่างนี้</p>
</Popup>
Before Fixed
Before Change Fixed

-this fix is due to the popup component is fixed by itself and cannot bypass by class.
-styling by class
@dhanavadh dhanavadh requested review from MasterIceZ and neennera July 8, 2025 16:34
Copy link
Member

@MasterIceZ MasterIceZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please check whether you're using class or className.

`}
>
<div class="text-center w-full px-4 h-full overflow-y-auto">
<div class={`w-full h-full overflow-hidden ${className}`}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try using the cn function to merge the classes together.

Suggested change
<div class={`w-full h-full overflow-hidden ${className}`}>
<div class={cn("w-full h-full overflow-hidden", className)}>

- Add cn for proper class merging
- Replace className with additionalClasses for Astro This is for additional class
Copy link
Member

@MasterIceZ MasterIceZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@dhanavadh dhanavadh merged commit 2e23f22 into dev Jul 8, 2025
7 checks passed
@dhanavadh dhanavadh removed the request for review from neennera July 8, 2025 18:01
@dhanavadh dhanavadh deleted the fix/firstdate/popup branch July 8, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants