-
Couldn't load subscription status.
- Fork 0
[Feature] rpkm home #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a static landing page for the RPKM home section and ties it into the overall site layout, including styling and dependency updates.
- Registers custom fonts and CSS variables in global styles
- Adds new RPKM pages: home, workshops, and summary, with navbar and footer layout
- Updates layout components and configuration for server output and proxy support
Reviewed Changes
Copilot reviewed 43 out of 111 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/global.css | Imported new fonts and defined CSS variables |
| src/pages/rpkm/home/index.astro | Added RPKM home page markup and buttons |
| src/pages/rpkm/workshops/index.astro | Added RPKM workshops page template |
| src/pages/rpkm/summary/index.astro | Added RPKM summary page template |
| src/layouts/rpkm/WithNavbar.astro | Configured RPKM navbar layout with background |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (6)
src/pages/rpkm/home/index.astro:12
- Tailwind uses
whitespace-nowrapinstead oftext-nowrap; update the class accordingly.
<ButtonRpkm href="/rpkm/summary" class="mx-auto text-nowrap" size="lg" color='pink'>รวมกิจกรรมรับเพื่อนก้าวใหม่</ButtonRpkm>
src/pages/rpkm/workshops/index.astro:7
- Pass a
variantprop (e.g.,variant="workshops") toLayoutso it uses the correct background image for this page.
<Layout>
src/pages/rpkm/summary/index.astro:7
- Pass a
variantprop (e.g.,variant="eventSummary") toLayoutso it uses the correct background image for this page.
<Layout>
src/components/common/Footer.astro:5
- The prop name
varientis misspelled; consider renaming tovariantfor consistency.
varient?: "firstdate" | "rpkm_home";
src/components/firstdate/Footer.astro:48
- There's a stray closing
</a>tag without a matching opening tag; remove it to fix the HTML structure.
</a>
.gcloudignore:15
- Ignoring the entire
public/directory will exclude static assets from deployment; consider removing or refining this rule to allow images to be uploaded.
public/
| @@ -0,0 +1,9 @@ | |||
| --- | |||
| import Sample from "@/components/rpkm/sample.astro"; | |||
Copilot
AI
Jul 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Remove the unused Sample import since it's not referenced in the template to reduce clutter.
| import Sample from "@/components/rpkm/sample.astro"; |
| @@ -0,0 +1,9 @@ | |||
| --- | |||
| import Sample from "@/components/rpkm/sample.astro"; | |||
Copilot
AI
Jul 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Remove the unused Sample import since it's not referenced in the template to reduce clutter.
| import Sample from "@/components/rpkm/sample.astro"; |
| --- | ||
|
|
||
| <Layout variant="rpkm_home"> | ||
| <div class='min-h-full w-full flex flex-col gap gap-8 mb-8'> |
Copilot
AI
Jul 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a duplicate Tailwind utility class gap; remove the redundant one to clean up the markup.
| <div class='min-h-full w-full flex flex-col gap gap-8 mb-8'> | |
| <div class='min-h-full w-full flex flex-col gap-8 mb-8'> |
| <Layout variant="rpkm_home"> | ||
| <div class='min-h-full w-full flex flex-col gap gap-8 mb-8'> | ||
| <h1 class="text-center text-4xl font-bold mt-4">รับเพื่อนก้าวใหม่ 2025</h1> | ||
| <div class=' bg-white h-[600px] w-full'>sdf]</div> |
Copilot
AI
Jul 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be placeholder text sdf] with no intended content; replace it with the intended markup or remove it.
| <div class=' bg-white h-[600px] w-full'>sdf]</div> | |
| <div class=' bg-white h-[600px] w-full'></div> |
just a static landing page for rpkm home