-
Couldn't load subscription status.
- Fork 0
[Feature] add react & common dialog #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates React dialog support and common UI components, updates global typography, and adds new pages for the RPKM and FirstDate sections with performance and health-check tooling.
- Added custom fonts and CSS variables in global styles
- Initialized a React-based DialogManager and hooks for global dialogs
- Created new Popup, Dialog, and button components and wired them into RPKM/FirstDate pages
- Expanded home page with API health check and performance measurements
Reviewed Changes
Copilot reviewed 46 out of 114 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/global.css | Imported new fonts and declared CSS variables |
| src/lib/dialogManager.ts | Implemented global DialogManagerV2 for React dialogs |
| src/hooks/useDialog.ts | Added useDialog hook to manage dialog state and events |
| src/components/common/react/Dialog.tsx | Created React Dialog component with backdrop and events |
| src/components/common/Popup.astro | Added Astro Popup component for modal-like UI |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
src/components/common/Footer.astro:17
- The key
rpkm-workshopsinbgGradientdoesn’t match thevariantvalue passed from the layout (e.g.,workshops). Align these names so the correct gradient is applied.
"rpkm-workshops": {
| } | ||
|
|
||
| /* Font Family Registrations */ | ||
| @theme { |
Copilot
AI
Jul 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSS custom properties should be declared under :root (or html) rather than using a non-standard @theme at-rule to ensure broad browser support.
| @theme { | |
| :root { |
| let apiLoadTime: number = 0; | ||
| let imageLoadTime: number = 0; | ||
| const startTime = performance.now(); |
Copilot
AI
Jul 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling performance.now() in the SSR frontmatter measures server‐side render time, not client‐side latency. Consider moving this measurement into the client <script> block for accurate network timing.
No description provided.