Skip to content

feat: safer deployment.yaml #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: 💥
merged 2 commits into from
Jul 4, 2025
Merged

feat: safer deployment.yaml #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e57c7f
feat: safer deployment.yaml
RawSalmon69 Jul 4, 2025
d541ad0
Merge branch 'dev' into origin/dev/dev-protect
RawSalmon69 Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 56 additions & 36 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,24 +72,6 @@ jobs:
- name: Set up Cloud SDK
uses: google-github-actions/setup-gcloud@v2

- name: Upload static assets to Cloud Storage (Dev)
run: |
# Upload Astro static assets
if [ -d "./dist/client/_astro" ]; then
gsutil -m rsync -r -d ./dist/client/_astro gs://${{ env.BUCKET_NAME }}/_astro/
fi

# Upload public images
if [ -d "./public/images" ]; then
gsutil -m cp -r ./public/images/* gs://${{ env.BUCKET_NAME }}/images/ || true
fi

# Set cache control headers for static assets
gsutil -m setmeta -h "Cache-Control:public, max-age=31536000, immutable" \
"gs://${{ env.BUCKET_NAME }}/_astro/**" || true
gsutil -m setmeta -h "Cache-Control:public, max-age=86400" \
"gs://${{ env.BUCKET_NAME }}/images/**" || true

- name: Build and push Docker image (Dev)
run: |
# Build image with build args
Expand Down Expand Up @@ -121,6 +103,34 @@ jobs:
SERVICE_URL=$(gcloud run services describe ${{ env.SERVICE_NAME }} --region=${{ env.REGION }} --format="value(status.url)")
echo "Development service deployed to: $SERVICE_URL"

- name: Upload static assets to Cloud Storage (Dev)
run: |
# Only upload if Cloud Run deployment succeeded
echo "Uploading static assets after successful deployment..."

# Upload Astro static assets
if [ -d "./dist/client/_astro" ]; then
gsutil -m rsync -r -d ./dist/client/_astro gs://${{ env.BUCKET_NAME }}/_astro/
echo "✅ Uploaded _astro assets"
else
echo "❌ No _astro directory found"
exit 1
fi

# Upload public images
if [ -d "./public/images" ]; then
gsutil -m cp -r ./public/images/* gs://${{ env.BUCKET_NAME }}/images/ || true
echo "✅ Uploaded images"
fi

# Set cache control headers for static assets
gsutil -m setmeta -h "Cache-Control:public, max-age=31536000, immutable" \
"gs://${{ env.BUCKET_NAME }}/_astro/**" || true
gsutil -m setmeta -h "Cache-Control:public, max-age=86400" \
"gs://${{ env.BUCKET_NAME }}/images/**" || true

echo "✅ Static assets uploaded successfully"

# Production deployment
deploy-prod:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -179,24 +189,6 @@ jobs:
- name: Set up Cloud SDK
uses: google-github-actions/setup-gcloud@v2

- name: Upload static assets to Cloud Storage (Prod)
run: |
# Upload Astro static assets
if [ -d "./dist/client/_astro" ]; then
gsutil -m rsync -r -d ./dist/client/_astro gs://${{ env.BUCKET_NAME }}/_astro/
fi

# Upload public images
if [ -d "./public/images" ]; then
gsutil -m cp -r ./public/images/* gs://${{ env.BUCKET_NAME }}/images/ || true
fi

# Set cache control headers for static assets
gsutil -m setmeta -h "Cache-Control:public, max-age=31536000, immutable" \
"gs://${{ env.BUCKET_NAME }}/_astro/**" || true
gsutil -m setmeta -h "Cache-Control:public, max-age=86400" \
"gs://${{ env.BUCKET_NAME }}/images/**" || true

- name: Build and push Docker image (Prod)
run: |
# Build image with build args
Expand Down Expand Up @@ -228,6 +220,34 @@ jobs:
SERVICE_URL=$(gcloud run services describe ${{ env.SERVICE_NAME }} --region=${{ env.REGION }} --format="value(status.url)")
echo "Production service deployed to: $SERVICE_URL"

- name: Upload static assets to Cloud Storage (Prod)
run: |
# Only upload if Cloud Run deployment succeeded
echo "Uploading static assets after successful deployment..."

# Upload Astro static assets
if [ -d "./dist/client/_astro" ]; then
gsutil -m rsync -r -d ./dist/client/_astro gs://${{ env.BUCKET_NAME }}/_astro/
echo "✅ Uploaded _astro assets"
else
echo "❌ No _astro directory found"
exit 1
fi

# Upload public images
if [ -d "./public/images" ]; then
gsutil -m cp -r ./public/images/* gs://${{ env.BUCKET_NAME }}/images/ || true
echo "✅ Uploaded images"
fi

# Set cache control headers for static assets
gsutil -m setmeta -h "Cache-Control:public, max-age=31536000, immutable" \
"gs://${{ env.BUCKET_NAME }}/_astro/**" || true
gsutil -m setmeta -h "Cache-Control:public, max-age=86400" \
"gs://${{ env.BUCKET_NAME }}/images/**" || true

echo "✅ Static assets uploaded successfully"

# Test job for PRs
test:
runs-on: ubuntu-latest
Expand Down
Loading