Dev : Fix by QA #83
Merged
Dev : Fix by QA #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-added staff scan qr page
added staff-qr page
- Fixed Staff-qr handling error - Fix error type assertions in staff/event/index.astro - Remove unused imports and variables
…/fdrpkm68-frontend into feat/firstdate/staff-qr
- Added auth functions getAuthToken() and getAuthHeaders() in api.ts - Fixed body stream error when scan qr code - Added handle error when user is not exist and when user scan wrong qr
- fix ButtonFd not send data
- Fixed no events active layout
…/fdrpkm68-frontend into feat/firstdate/staff-qr
* feat: added staff scan qr page -added staff scan qr page * fix: firstdate staff bg * feat: add @yudiel/react-qr-scanner * Feat: added staff-qr page added staff-qr page * chore: fix middleware doesn't work * feat: Implement qr scan with api * fix: staff-qr code - Fixed Staff-qr handling error - Fix error type assertions in staff/event/index.astro - Remove unused imports and variables * fix: qr scan error, body stream err, cannot send cookie to backend err - Added auth functions getAuthToken() and getAuthHeaders() in api.ts - Fixed body stream error when scan qr code - Added handle error when user is not exist and when user scan wrong qr * Fix: alternative form handle error - fix ButtonFd not send data * fix: no event active layout - Fixed no events active layout * fix: qrcode --------- Co-authored-by: neennera <[email protected]> Co-authored-by: Thukdanai Thaothawin <[email protected]> Co-authored-by: Borworntat Dendumrongkul <[email protected]>
(cherry picked from commit 77bf8bf)
Fix/qr code not scan
There was a problem hiding this comment.
Pull Request Overview
This PR implements bug fixes and UI improvements identified during QA testing. The changes address QR code refresh behavior, error handling logic, footer alignment, and profile data processing.
- Modified QR code auto-reload from 30 seconds to 1 second with enhanced interval management
- Simplified error handling by removing "Check-in not found" condition
- Updated footer layout to center-align contact information elements
- Fixed profile data processing to properly handle allergy/medication flags and use empty strings instead of null values
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/pages/firstdate/qrcode/index.astro | Updated QR code auto-reload timing and added interval management comment |
| src/lib/eventAPI.ts | Removed "Check-in not found" error condition from event status check |
| src/components/firstdate/Footer.astro | Added center alignment to contact information sections |
| src/components/common/profile/EditProfile.tsx | Enhanced profile data processing with proper boolean flags and empty string handling |
[Feat][RPKM] Group API
RawSalmon69
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.