Minor fix #85

MasterIceZ · 2025-07-18T09:40:00Z

No description provided.

-added staff scan qr page

added staff-qr page

- Fixed Staff-qr handling error - Fix error type assertions in staff/event/index.astro - Remove unused imports and variables

…/fdrpkm68-frontend into feat/firstdate/staff-qr

- Added auth functions getAuthToken() and getAuthHeaders() in api.ts - Fixed body stream error when scan qr code - Added handle error when user is not exist and when user scan wrong qr

- fix ButtonFd not send data

- Fixed no events active layout

…/fdrpkm68-frontend into feat/firstdate/staff-qr

* feat: added staff scan qr page -added staff scan qr page * fix: firstdate staff bg * feat: add @yudiel/react-qr-scanner * Feat: added staff-qr page added staff-qr page * chore: fix middleware doesn't work * feat: Implement qr scan with api * fix: staff-qr code - Fixed Staff-qr handling error - Fix error type assertions in staff/event/index.astro - Remove unused imports and variables * fix: qr scan error, body stream err, cannot send cookie to backend err - Added auth functions getAuthToken() and getAuthHeaders() in api.ts - Fixed body stream error when scan qr code - Added handle error when user is not exist and when user scan wrong qr * Fix: alternative form handle error - fix ButtonFd not send data * fix: no event active layout - Fixed no events active layout * fix: qrcode --------- Co-authored-by: neennera <[email protected]> Co-authored-by: Thukdanai Thaothawin <[email protected]> Co-authored-by: Borworntat Dendumrongkul <[email protected]>

(cherry picked from commit 77bf8bf)

Fix/qr code not scan

[Feat][RPKM] Group API

Copilot

Pull Request Overview

This pull request implements several improvements and fixes across the application, including new group management features, code refactoring, and UI updates. The changes primarily focus on group functionality, profile management, and code organization.

Key changes include:

Added comprehensive group management API functions (join, leave, fetch by invite code)
Refactored profile components to share common types and avatar mappings
Updated UI components with dynamic group member counts and improved error handling

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/lib/groupAPI.ts	Added new API functions for group operations (join, leave, fetch by invite code)
src/lib/eventAPI.ts	Simplified error condition checking in event status
src/components/rpkm/rubpuen/UserProfile.tsx	Refactored to use shared profile types and improved null safety
src/components/rpkm/rubpuen/GroupProfile.tsx	Refactored to use shared avatar mapping and profile types
src/components/rpkm/data/profile.ts	New shared module for profile types and avatar mappings
src/components/rpkm/components/house-picker.astro	Updated import path for house data
src/components/rpkm/components/group-picker.astro	Enhanced with dynamic group functionality and error handling
src/components/firstdate/Footer.astro	Removed Instagram contact section and improved layout
src/components/common/profile/EditProfile.tsx	Fixed prefix values and improved form data handling
src/components/common/Footer.astro	Removed Instagram contact section

Copilot · 2025-07-18T09:41:33Z

src/lib/groupAPI.ts

+  if (!token) {
+    return {
+      success: false,
+      error: "กรุณาเข้าสู่ระบบก่อนลงทะเบียน",


The error message 'กรุณาเข้าสู่ระบบก่อนลงทะเบียน' (Please log in before registering) is misleading for a function that fetches group data by invite code. It should indicate authentication is required for accessing group information.

Suggested change

error: "กรุณาเข้าสู่ระบบก่อนลงทะเบียน",

error: "กรุณาเข้าสู่ระบบเพื่อเข้าถึงข้อมูลกลุ่ม",

Copilot · 2025-07-18T09:41:33Z

src/lib/groupAPI.ts

+  if (!token) {
+    return {
+      success: false,
+      error: "กรุณาเข้าสู่ระบบก่อนลงทะเบียน",


The error message 'กรุณาเข้าสู่ระบบก่อนลงทะเบียน' is inappropriate for a group joining function. It should specifically mention group joining rather than registration.

Suggested change

error: "กรุณาเข้าสู่ระบบก่อนลงทะเบียน",

error: "กรุณาเข้าสู่ระบบก่อนเข้าร่วมกลุ่ม",

Copilot · 2025-07-18T09:41:33Z

src/lib/groupAPI.ts

+  if (!token) {
+    return {
+      success: false,
+      error: "กรุณาเข้าสู่ระบบก่อนลงทะเบียน",


The error message 'กรุณาเข้าสู่ระบบก่อนลงทะเบียน' is misleading for a group leaving function. It should indicate authentication is required for leaving a group.

Suggested change

error: "กรุณาเข้าสู่ระบบก่อนลงทะเบียน",

error: "กรุณาเข้าสู่ระบบก่อนออกจากกลุ่ม", // "Please log in before leaving the group"

Copilot · 2025-07-18T09:41:34Z

src/lib/groupAPI.ts

+export async function joinGroup(
+  inviteCode: string,
+  authToken?: string
+): Promise<ApiResponse<unknown>> {


The return type 'unknown' is too vague. Based on line 80, the API returns '{ message: string }', so the return type should be 'Promise<ApiResponse<{ message: string }>>' for better type safety.

Suggested change

): Promise<ApiResponse<unknown>> {

): Promise<ApiResponse<{ message: string }>> {

Copilot · 2025-07-18T09:41:34Z

src/components/rpkm/components/group-picker.astro

+      groupDefaultView?.classList.add("hidden");
+      groupMemberView?.classList.remove("hidden");
+    } else {
+      console.error("Failed to leave group before:", response.error);


The error message 'Failed to leave group before:' is confusing and doesn't match the context. This appears to be logging an error for a failed join group operation, not a leave operation.

Suggested change

console.error("Failed to leave group before:", response.error);

console.error("Failed to join group:", response.error);

Copilot · 2025-07-18T09:41:34Z

src/components/common/profile/EditProfile.tsx

          Authorization: `Bearer ${getAuthToken()}`,
        },
      });
+      const raw_data = reponse.data as EditProfileFormData;


Variable name 'reponse' is misspelled. It should be 'response'.

Copilot · 2025-07-18T09:41:35Z

src/components/common/profile/EditProfile.tsx

+        illness: data.user.hasChronicDiseases ? data.user.illness : "",
      };

      const reponse = await api.patch("/user/update", formData, {


Variable name 'reponse' is misspelled. It should be 'response'.

dhanavadh and others added 30 commits July 13, 2025 22:27

feat: added staff scan qr page

3631609

-added staff scan qr page

Merge branch 'dev' into feat/firstdate/staff-qr

fe86339

fix: firstdate staff bg

076210b

Merge branch 'dev' into feat/firstdate/staff-qr

a25dc69

feat: add @yudiel/react-qr-scanner

2eb62c2

Merge branch 'dev' into feat/firstdate/staff-qr

4cbcbd3

Merge branch 'dev' into feat/firstdate/staff-qr

a70b642

Merge branch 'dev' into feat/firstdate/staff-qr

2fa23d2

Feat: added staff-qr page

560d6a0

added staff-qr page

Merge branch 'dev' into feat/firstdate/staff-qr

382c2c8

chore: fix middleware doesn't work

a5e278f

feat: Implement qr scan with api

9846fda

Merge branch 'dev' into feat/firstdate/staff-qr

6b9742a

fix: staff-qr code

9447040

- Fixed Staff-qr handling error - Fix error type assertions in staff/event/index.astro - Remove unused imports and variables

Merge branch 'feat/firstdate/staff-qr' of https://github.com/isd-sgcu…

d3ac27c

…/fdrpkm68-frontend into feat/firstdate/staff-qr

Merge branch 'dev' into feat/firstdate/staff-qr

cd6e983

fix: conflicts

e53584f

fix: qr scan error, body stream err, cannot send cookie to backend err

707f4a7

- Added auth functions getAuthToken() and getAuthHeaders() in api.ts - Fixed body stream error when scan qr code - Added handle error when user is not exist and when user scan wrong qr

Fix: alternative form handle error

8395fc4

- fix ButtonFd not send data

fix: no event active layout

919a945

- Fixed no events active layout

Merge branch 'dev' into feat/firstdate/staff-qr

9523a05

Merge branch 'feat/firstdate/staff-qr' of https://github.com/isd-sgcu…

7878eff

…/fdrpkm68-frontend into feat/firstdate/staff-qr

feat: getGroupByInviteCode

80569df

fix: fest content

0b94782

fix: qrcode in /events go to /firstdate/qrcode

e0c6a73

add : checkin not found & remove freshmennight

f6e264a

feat: joinGroup and leaveGroup

d0acd9f

add: fix event period

09d2d67

fix: staff with navbar

1c252d1

BadLuckZ and others added 13 commits July 18, 2025 01:24

Update Routes.ts

0bd0a31

feat: add nonStartedRoutes time constraint whitelist

82d9fc3

(cherry picked from commit 77bf8bf)

fix : home & map unclickable

c3c7d6a

fix: new Date()

8448136

Merge pull request #80 from isd-sgcu/fix/qr-code-not-scan

05e7123

Fix/qr code not scan

fix: qr load

375308a

Merge branch 'main' into dev

be3ec12

fix: check in not found event

366cf26

fix: qa profile , firstdate register

c56c4d6

Merge branch 'main' into dev

2b8d55e

Merge pull request #79 from isd-sgcu/feat/rpkm/groupAPI

b8cf671

[Feat][RPKM] Group API

fix: edit profile

86c9d78

chore: remove ig

3f2f88b

Copilot AI review requested due to automatic review settings July 18, 2025 09:40

Merge branch 'main' into dev

aa7423e

Copilot AI reviewed Jul 18, 2025

View reviewed changes

RawSalmon69 approved these changes Jul 18, 2025

View reviewed changes

RawSalmon69 merged commit 0c6ab70 into main Jul 18, 2025
10 checks passed

neennera added 3 commits July 19, 2025 16:03

fix: qrcode

96e5daf

Merge branch 'dev' into feat/firstdate/staff-qr

6a6f02d

Merge branch 'feat/firstdate/staff-qr' into fix/qr-code-not-scan

ac39a95

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Minor fix #85

Minor fix #85

Uh oh!

MasterIceZ commented Jul 18, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 18, 2025

Uh oh!

Copilot AI Jul 18, 2025

Uh oh!

Copilot AI Jul 18, 2025

Uh oh!

Copilot AI Jul 18, 2025

Uh oh!

Copilot AI Jul 18, 2025

Uh oh!

Copilot AI Jul 18, 2025

Uh oh!

Copilot AI Jul 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

	error: "กรุณาเข้าสู่ระบบก่อนลงทะเบียน",
	error: "กรุณาเข้าสู่ระบบเพื่อเข้าถึงข้อมูลกลุ่ม",

	error: "กรุณาเข้าสู่ระบบก่อนลงทะเบียน",
	error: "กรุณาเข้าสู่ระบบก่อนเข้าร่วมกลุ่ม",

	error: "กรุณาเข้าสู่ระบบก่อนลงทะเบียน",
	error: "กรุณาเข้าสู่ระบบก่อนออกจากกลุ่ม", // "Please log in before leaving the group"

	): Promise<ApiResponse<unknown>> {
	): Promise<ApiResponse<{ message: string }>> {

	console.error("Failed to leave group before:", response.error);
	console.error("Failed to join group:", response.error);

Uh oh!

Minor fix #85

Minor fix #85

Uh oh!

Conversation

MasterIceZ commented Jul 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants