Feat/annoucement card #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think each card should be clicked and redirect to its own article page, so i added the 5th prop (linkHref) to the component. |
punchanabu
requested changes
Sep 15, 2024
|
อ่อแล้วก็ของ Card มันมีของ mobile size ด้วยนะ designer เพิ่งเพิ่มมา tailwind-responsive |
|
Already added fallback leaw naka
and card size for mobile
|
punchanabu
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Annoucement Card with trimTitle for too long title
Screenshots or GIFs (if applicable)
Already added to Playground