[pull] master from deepmodeling:master - #319
Merged
Merged
Conversation
## Summary Backport `0004-register-lammps-kokkos-plugin-styles.patch` from `conda-forge/deepmd-kit-feedstock@d02138263b0b30629fe28c68c8bcecc2b8644513`. Runtime LAMMPS plugins do not consume the `PairStyle` declarations used by the built-in package machinery, so explicitly register: - `deepmd/kk` - `deepmd/kk/device` - `deepmd/kk/host` - `dpa4spin/kk` - `dpa4spin/kk/device` - `dpa4spin/kk/host` The newly registered Kokkos plugin styles are attributed to **Tiancheng Li** via `plugin.author`. ## Validation - Single-file change derived from the feedstock patch, with only the requested author attribution adjusted. - Existing non-Kokkos plugin author fields are unchanged. - Split from #5985 so plugin registration can be reviewed independently. - Full build/runtime validation is left to upstream CI. Agent: ChatGPT Model: GPT-5.6 Sol <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added Kokkos-enabled support for DeepMD and DPA-4Spin pair styles. - Added host and device runtime variants for improved compatibility across supported execution environments. - Registered additional pair-style aliases so these implementations can be selected through standard runtime configuration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> ## Dependencies and follow-up validation Merge order: corrected #5987, then #5989, then this PR. The Kokkos registrations in this PR depend on the compatibility boundary from #5987 and the shared-runtime linkage from #5989. Validated the combined changes with `DEEPMD_LAMMPS_KOKKOS=ON`, `PKG_PLUGIN=ON`, and `PKG_KOKKOS=ON` against `stable_22Jul2025_update5`, `patch_10Sep2025`, and `patch_20Aug2026`. In every build, `plugin load` succeeded and `plugin list` reported all six aliases: `deepmd/kk`, `deepmd/kk/device`, `deepmd/kk/host`, `dpa4spin/kk`, `dpa4spin/kk/device`, and `dpa4spin/kk/host`. Coding agent: Codex Codex version: codex-cli 0.149.0 Model: gpt-5.6-sol Reasoning effort: xhigh Co-authored-by: OutisLi <137472077+OutisLi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )