Replace custom secp256k1/ECDSA with Zig std lib #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
iskyd
commented
Apr 5, 2025
iskyd
commented
- Removed internal secp256k1 and ecdsa custom implementations
- Migrated to Zig's standard library modules
|
Related to this bug ziglang/zig#23503 |
|
This pr introduce verifyPrehashed and finalizePrehashed. This is what is needed, otherwise do not perform doubleSha but just a single hash with sha256 and pass that to ecdsa sign. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.